From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uIG8DuKpe2LwSAEAbAwnHQ (envelope-from ) for ; Wed, 11 May 2022 14:19:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OKjADuKpe2K+FAEAauVa8A (envelope-from ) for ; Wed, 11 May 2022 14:19:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E2EC6E183 for ; Wed, 11 May 2022 14:19:45 +0200 (CEST) Received: from localhost ([::1]:47680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nolJg-0007br-FK for larch@yhetil.org; Wed, 11 May 2022 08:19:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nolJ1-0007Yr-IM for emacs-orgmode@gnu.org; Wed, 11 May 2022 08:19:03 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:34685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nolIz-00084F-Sn for emacs-orgmode@gnu.org; Wed, 11 May 2022 08:19:03 -0400 Received: by mail-pf1-x42c.google.com with SMTP id a11so1848447pff.1 for ; Wed, 11 May 2022 05:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=xUbQQMXTVHIdhPeEkzBlOQIrfpf/ypd1vZh5ZCnkA4M=; b=RX3C8uNOfdPoHTaOUUHuPHlp7I+6bpLXNzNmXr+aec453vrtls/H5+9rOtA9cGb4/J Czev5MH8paCFqgm9DSCw0sHYp/DfhRFwitUlFyRfTaoLr3mGprCB8RWbvrpgQvB4n41I b6eLV1it3eCodOEKqPT1iyQ+3HK35OMxoZ8Q5EMaJ0x1eVunEXAyTFaOlkUwrl74FcTw hAZZoUVn9iIOEWfRE5Xz1U6olIf3Dm0F4+bWa821ThO2bQfq0icoZpy/TrZswmIz9gjL NC+CO0SYjz7/AH5kdLDhJQqaZCtfQTRu4CfPWH+GKGSwPn84xlSD84Pjs4ipRtAV5GHA 0yUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=xUbQQMXTVHIdhPeEkzBlOQIrfpf/ypd1vZh5ZCnkA4M=; b=NooqXxvjkOyfKLd0jN0VbSTWMlxGNk0TmfqgurloFXIpjnBUoaQWCeamcP8aJrp7c5 CxPaZ8yoNB58FWqYyeF07qLRypooSo9dFbxYgiwc8eVYD/d1ssAykf2n2168ozx/1Q7t C0b40nqEbqXIndJfvRn/cNNOs2l0tPtBMOJTqA/nG58MycOuoRVHdBONaX6z2MFNXfGw JcAAAZmp90O9fzDQv+rltGMYyRTJm8QrRRcwiytzB6Yu0qbwVpG7RVPNEfmWEDlNZuud 9rMYQh+5vBoBSJrCTL9Jh/Au/xeXd2eLzd/IFXgz7931lOC0QzX1zyVHB0jaGi9BWbmM WDWQ== X-Gm-Message-State: AOAM530JKCN5kwjTNSg1qyntWRkg6gp7UOfeZE/CpGwRE1C5uFIiI46X Xf9iSZr+YM2BgEAVgNWqCg4YrZEXTeyv6g== X-Google-Smtp-Source: ABdhPJwflqNuVrk6bACuZtwHGoZFLNnrzSv3cLrtU2lk125iqRYLgXXWigYnuuhpMfRlc8O7SMKTjw== X-Received: by 2002:a05:6a00:15c7:b0:510:48c9:f302 with SMTP id o7-20020a056a0015c700b0051048c9f302mr24957562pfu.23.1652271540640; Wed, 11 May 2022 05:19:00 -0700 (PDT) Received: from localhost ([66.154.104.4]) by smtp.gmail.com with ESMTPSA id m21-20020a170902bb9500b0015e8d4eb26esm1680200pls.184.2022.05.11.05.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 05:18:59 -0700 (PDT) From: Ihor Radchenko To: Pride Allman Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-table.el: Use booktabs on org-table-export In-Reply-To: References: Date: Wed, 11 May 2022 20:19:44 +0800 Message-ID: <87a6bojm73.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=yantar92@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652271585; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xUbQQMXTVHIdhPeEkzBlOQIrfpf/ypd1vZh5ZCnkA4M=; b=QdE/88rxagX/NQfOZhtF1FaZipXDqAUYYFCSMgCU8Q+o4moZY2EgyORkM6hlGswVS9A5Kj EvBtFjhYPl7KxXmDb7gufolJX9zsh71p7oS2WgyB75fIlliDcZ/aKSeJaKTBsSEh/4T2jv JhiPwoFrzkkq/cZfMTeb2mJ7Qw7XGK5MW6x6N7MREU5q4PCXxQGLjZkWqnu4Uj8YspTC7W ONu0LAh/jWrlXME9Nv748/WxCybgc9YkZDjesnWWoBG+0kULVjrDePoVhc/ZQKI9aCUq7p xP6PwSoXN/yxCEQJ+uNrq6QWi7bkGQ7pJ/elShU+4IMX22CZesaD/72uC3Pnrg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652271585; a=rsa-sha256; cv=none; b=cOQ/AxNDrkpxy1MBnFdGIvQ0xjB5PKm8fEFIC0O5T5u3xu3kMIyo0BFIakOsSFdF3z/zho 8/2c2nXZWneJJUpymJHCW+elr+wTIx9Jzx0Xkd8ytKF6sCLqOy3gomOqOlK91OHCBlEqik xE7/ymwOxvCe0N2yqk9ysX6qk97qI0OaIaq/5lZ2iR34mFGW/wLqdkmdQ9y/mu/ZIB9K5B dYi9t85ty1RqUmHnchbfYV2esyoXf0eoUmErGaCsehK4WpEzM0CQ9wbMXrtB4mO0ZlCjnO 3Jdars3V7rvZLLv1sNeo+AJUzQUnR8pS0/I607rCuiA0+kD6EJSZqwVxqkqNog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RX3C8uNO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RX3C8uNO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E2EC6E183 X-Spam-Score: -8.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9LNefhO6pdDM Pride Allman writes: > This is my first patch so hopefully I followed the instructions correctly, Thanks for the patch! Patches are always welcome, though I do not fully agree with the approach you used in this particular one. > While using ~org-table-export~ on a table directly even with > ~org-latex-tables-booktabs~ set to ~t~, it exports a normal table instead > of booktabs table. But on the same situation, if you export the whole > buffer the table will be exported according to booktabs. I also find this discrepancy awkward. Normally, Org export options are chosen according to org-export-options-alist (see the docstring) and the equivalent variables in specific export backend (see org-export-define-backend 'latex in ox-latex.el). However, when you look into orgtbl-to-latex, orgtbl-to-html, orgtbl-to-texinfo, and orgtbl-to-unicode, they all overwrite certain export settings by force. Sometimes, even not leaving the user an option to choose. All those (list :option value ...) are force-overwriting the _global_ export defaults (see orgtbl-to-latex calling orgtbl-to-generic that calls org-export-get-environment with third argument) , including :latex-tables-booktabs. This is by design. While I do not like the current design, your patch will only create even more inconsistencies; The same problem will remain for other force-overwritten options. Best, Ihor