From: Ihor Radchenko <yantar92@posteo.net>
To: Daniel Kraus <daniel@kraus.my>, Bastien <bzg@gnu.org>
Cc: numbchild@gmail.com, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: ob-clojure eval error when has comment at end of code line
Date: Fri, 28 Oct 2022 04:05:24 +0000 [thread overview]
Message-ID: <87a65gmw3f.fsf@localhost> (raw)
In-Reply-To: <878rl1a1e0.fsf@kraus.my>
Daniel Kraus <daniel@kraus.my> writes:
> @Ihor, a few developer related questions:
> - I wanted to add a test, how can I run only test-ob-clojure?
make test BTEST_POST="-L /path/to/cider.el" BTEST_OB_LANGUAGES="clojure" BTEST_RE="ob-clojure"
Note that our tests demand cider executable and library.
Testing with external libraries is a bit manual.
> - What should I use for indention? Looking in ob-clojure and org.el
> it seems that using tabs with tab-width 8 is standard but there's
> quite a few lines where it's spaces only.
That is a good question. I guess, just Emacs default.
Our code is not consistent here...
Maybe Bastien can clarify better.
> - If this simple patch for example or fixing tests is good,
> should I just install it?
Yes. We have some conventions documented at
https://orgmode.org/worg/org-maintenance.html#maintainer-role
> Can I "freely" install minor changes to ob-clojure or should
> everything go over the mailinglist?
Minor changes do not need to be discussed. We generally discuss new
features or changes that affect multiple libraries.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-28 4:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 4:08 ob-clojure eval error when has comment at end of code line Christopher M. Miles
2022-10-26 7:30 ` Ihor Radchenko
2022-10-27 12:25 ` Daniel Kraus
2022-10-27 14:17 ` Max Nikulin
2022-10-28 4:05 ` Ihor Radchenko [this message]
2022-10-28 9:40 ` ob-clojure session support (was: ob-clojure eval error when has comment at end of code line) Daniel Kraus
2022-10-28 10:20 ` ob-clojure session support Bastien Guerry
2022-10-29 3:03 ` ob-clojure session support (was: ob-clojure eval error when has comment at end of code line) Ihor Radchenko
2022-10-29 8:07 ` ob-clojure session support Bastien Guerry
2022-10-30 11:33 ` ob-clojure session support (was: ob-clojure eval error when has comment at end of code line) Daniel Kraus
2022-10-30 12:45 ` Ihor Radchenko
2022-10-29 20:13 ` indent-tabs-mode in org " Daniel Kraus
2022-10-31 9:49 ` indent-tabs-mode in org Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a65gmw3f.fsf@localhost \
--to=yantar92@posteo.net \
--cc=bzg@gnu.org \
--cc=daniel@kraus.my \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).