From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kEbjHRXIv2OkPQAAbAwnHQ (envelope-from ) for ; Thu, 12 Jan 2023 09:43:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oD3xHBXIv2MGFwEAG6o9tA (envelope-from ) for ; Thu, 12 Jan 2023 09:43:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FB8E3864D for ; Thu, 12 Jan 2023 09:43:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFt9z-0003o5-RJ; Thu, 12 Jan 2023 03:42:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFt9w-0003nb-NI for emacs-orgmode@gnu.org; Thu, 12 Jan 2023 03:42:04 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFt9u-0006G5-Pz for emacs-orgmode@gnu.org; Thu, 12 Jan 2023 03:42:04 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 917CA2403E6 for ; Thu, 12 Jan 2023 09:42:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673512920; bh=4RQf+/p8Vplk1khGQFnU7bWeBxX09/4QFIGn3RRkBWs=; h=From:To:Cc:Subject:Date:From; b=E9wtaDdFrgJGjzj3g9tJOks/nkRV3MdWfHgJa4YOqNVr/RXH30cVHIFP+Ajczkt8M dbeAKp4BultQOm+C383UTRKAA8tmNB1K8JKR2RmW3jwxh2QCb4MkwnhmdEBO40T6/g 37CNOcsyoS01rsg60EbDNcMgqzor5nKCeTjqP4sSLMxN/cxqQegjsq6v03hmukrfOu i3QvW/S7YQHZbaBOT1SwkLnbgVGdNCnUqMlPT/QQfVTHooWPYcosI31JAW5Ek4tbIm EwGG+Qg1DBjNVEModq7QvR/pqst2ylENs1Sipp57TwzfReUoa/U1YwzXKwO3PTIXRe VUKGiHDpLWyJw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Nsyhl3XsGz9rxK; Thu, 12 Jan 2023 09:41:59 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87wn5sloz4.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> <87bknh5nva.fsf@localhost> <87358ovj53.fsf@t14.reltub.ca> <87a62vitpu.fsf@localhost> <87lemfqbwl.fsf@t14.reltub.ca> <87o7r6m8sf.fsf@t14.reltub.ca> <87fschfhke.fsf@localhost> <87wn5sloz4.fsf@t14.reltub.ca> Date: Thu, 12 Jan 2023 08:42:31 +0000 Message-ID: <87a62o9ma0.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673512980; a=rsa-sha256; cv=none; b=m4f+mCahNIk2VVeepvceczX879ZtZN2KFQpX0BWJor39NhFcCBcbAy/LGavhOl19IyeTim IBNy4Abo5VXC5eDGRS7Qs/4iP5xvKQSQl/tzJ7xEvPtwdhpcidEeVsV0QHqdxFGxeyzPnp BdLOgBM3BenAWBlXnii0mJ5DFlI0cWNJ0bof+q0xWLBvb5Ew8y039ao27v5pdZUJGA3gDq h/3N7vezrZGminXxsGcQnUplJfS45ZNg3wpJ9UWaYMs8TeZS6T+6MPaKdmadput3U1RG+g v0BZBaZ3floh/8nQ5ebdkyL3XknTRaJ2qrbDWtqR3ZX1qWXnAFFpFxFtmEOlSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=E9wtaDdF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673512980; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TjjRqFOgnfytRP4ojgjwRQGwwBNbQsQBBmfXWxxZgOA=; b=sKEdrB1U/O3Uj8ZWgr3ayA5WcloMXwBxOSYDSWafhjRZXZ0Wv+DOM90XWeAoFpST7t/FU0 /3bybnYNenoIqgGvOOrNzJphjwsglMgZl+qiQFQVmXSxse9YppJHylw9uT6nysCOg01FNg s9BVjdKZyR3DNcIY1JdDuBJ6Yk9e0Shbh1k4r60IWHY+f0lfDYnxPQtdikygLojFjUHu/4 FCWmcDhVyMsxc2U4+koNnzVpsv7jz0/VO89wIc1UQMzG0UsSdscrJ+BMDqDc9TR93pgokr +Mgk7m/XJJACh/A+73qFhzj4iKZS9kqzTd3tG/6tAwOwjG/55f9s8u115FLdVw== X-Migadu-Spam-Score: -6.05 X-Spam-Score: -6.05 X-Migadu-Queue-Id: 6FB8E3864D X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=E9wtaDdF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: heTc3fCdyeYZ Leo Butler writes: >> So, the test failure is real. >> >> https://orgmode.org/list/94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de >> might be related. > > Ihor, > > How do you want to treat the patch that was included? I think we should > have something like that to catch errors like these. And the failing > tests should be marked as known failures (that need to be fixed, > obviously). I note that both failures 3 & 4 are related to org's > built-in features. Are you referring to "failures" in your attachment? I think that your expectation is wrong here. Org does not clear the "*Org-Babel Error Output*" buffer upon running next src block during Emacs session - it is a good thing when you run multiple src blocks and want to see the errors/warnings produced. So, if we want to do some definitive assertions about "*Org-Babel Error Output*", we could kill "*Org-Babel Error Output*" (if any) before running the test that checks this buffer. As for ob-octave failures, I suspect that octave throws some warnings on CI machine. I currently don't have podman setup to run CI tests locally - you may try to play with the problematic ob-octave tests to identify the problem as described in https://git.sr.ht/~bzg/org-mode-tests/ -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at