From: Robert Pluim <rpluim@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix some emacs-30 byte-compile warnings
Date: Fri, 17 Feb 2023 16:33:49 +0100 [thread overview]
Message-ID: <87a61c1f36.fsf@gmail.com> (raw)
In-Reply-To: <87sff49ygr.fsf@localhost> (Ihor Radchenko's message of "Fri, 17 Feb 2023 14:08:04 +0000")
>>>>> On Fri, 17 Feb 2023 14:08:04 +0000, Ihor Radchenko <yantar92@posteo.net> said:
Ihor> Robert Pluim <rpluim@gmail.com> writes:
Ihor> 3 unexpected results:
Ihor> FAILED test-org-table/copy-field
Ihor> FAILED test-org-table/references/mode-string-N
Ihor> FAILED test-org-table/references/mode-string-none
>>
>> Hmm, at least the first one is because the code in the 't' branch of
>> (if (and (eq elements "") (not keep-empty))
>>
>> in org-table-make-reference now runs, and it results in
>>
>> (eval '(identity))'
>>
>> Of course fixing that causes other problems <sigh>
Ihor> Meanwhile, I fixed all the other warnings.
Ihor> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eea8da0315b4d9c43272f4ee87d752e651f1a0c0
Ihor> Now, only this org-table problem remains.
Ihor> It is clearly a bug of some kind - the code is not doing what it
Ihor> intended originally. But we need to understand org-table.el better to
Ihor> fix this...
Iʼve not had time to look at it further (probably my subconscious not
wanting to deal with org-table.el :-))
Robert
--
prev parent reply other threads:[~2023-02-17 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:57 [PATCH] Fix some emacs-30 byte-compile warnings Robert Pluim
2023-01-23 14:04 ` Ihor Radchenko
2023-01-23 17:28 ` Robert Pluim
2023-02-17 14:08 ` Ihor Radchenko
2023-02-17 15:33 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a61c1f36.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).