From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QFgJMSqiUmShbgEASxT56A (envelope-from ) for ; Wed, 03 May 2023 20:04:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iJzSMCqiUmRXEwAAauVa8A (envelope-from ) for ; Wed, 03 May 2023 20:04:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4923C3DC97 for ; Wed, 3 May 2023 20:04:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puGp8-0002gf-W6; Wed, 03 May 2023 14:03:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puGp2-0002gL-DT for emacs-orgmode@gnu.org; Wed, 03 May 2023 14:03:24 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puGou-0000mA-A2 for emacs-orgmode@gnu.org; Wed, 03 May 2023 14:03:24 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3CDB12402C7 for ; Wed, 3 May 2023 20:03:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683136994; bh=c3nVl0z88kB5BpPDfOFlvw3vT9ZoIthlJneviW9GmIc=; h=From:To:Cc:Subject:Date:From; b=CMG5264mx5X2kNPidq81cxblCFI8ahMAWB6h0jyIuLPxAMhd2nle+3px1T6eCJ7Mz FZtteig91nD7BPWqPRj3WTG19YXPAyEZ1H62Anbv9NBd+XkRMvidR9if3vtsm7oyoD 7bDVTmu6mcqvLrKpYP0B3URvGvfUITSTd5qORwmExZxK6bvyQvrHYQlgXmmf0ywZ3F xMm/eoA9m9vFANr9Oh9RNEYgDAJXwUyR7Z08wIErZ+a83OZR7+7DXZXbKNkVcZQtSM ocBdaDaN0Hr7PcZF4IlrfKpSPsPDCSjX37O4cbCKiF3AAL0rtagSCN+v0r9S1mxl01 IhSDrVAvFRx1g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QBPv56223z6tvm; Wed, 3 May 2023 20:03:13 +0200 (CEST) From: Ihor Radchenko To: Mehmet Tekman Cc: emacs-orgmode@gnu.org Subject: Re: [ANN] lisp/ob-tangle-sync.el In-Reply-To: <871qjx8qqf.fsf@gmail.com> References: <87r0rxabd4.fsf@localhost> <871qjx8qqf.fsf@gmail.com> Date: Wed, 03 May 2023 18:06:25 +0000 Message-ID: <87a5yluw66.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683137066; a=rsa-sha256; cv=none; b=Pjr0oyvH7uoM1TK1EtkAcYR7gRF/BAZ57q8Mx+oE3Wt1HUfdfmhji7SgmwXgoGyCRE4mdN z56euMHDubJwZ5lb4sf8PDRwSbKmGRSDek/p8gDc8bLQcFA15f1G6h+xONNsQBm6+HWiB1 HIUrwCpGH64uw6UJVEq283afLZl4ca1qo0OGQxt99pq/gLWcagLlU/BamxgURnaYj6rkTL 41AKv2AfEqoe1Qopcpaj7rdR1NbjHtvcnxgwEjTYnDQsiBeo4nMKY5yjbet5PGVjVOVnVM 8VIKgwv9pIX+9hKfzt9FJy9xv1ofixHPySPSy0Om079rCAHq4jxManJaVNYWsQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CMG5264m; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683137066; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fTT7/OephKD5uvp9o+P2GDHqT1yU7qDuxhGusqvOzgk=; b=kqkwn3ZgKCJy5DI7utgGvY8srJQchLooRVSSDabamKYV94ThZ0IDn1vhlrm4ZDGOlT+55F 42SqC7BZ2RWmoGyINef6d1ssZCkfBKiXo0Sg7czUCXqvCE0Z2iOIpRdieuCDjH3LRSI42j +VcaY4OPTrqbZFYFx+9wYBVsZppYDN/MctJl3ZdGtGLwmjgwtsVCDsLZUc0XwNFGsLgAMj SAQ2Fw6BkQ468doJMttSS6bBZQ0uECU6LRHGMN/53S9sSATa/0QF2IJqRUHsIDxIrF8CF5 BjOdG4kE9/uXbh7R66PWVm+/9/D/V8SBkBdMP9EcwY9NnQD8yctcQG3s2tYSZw== X-Migadu-Spam-Score: -6.39 X-Spam-Score: -6.39 X-Migadu-Queue-Id: 4923C3DC97 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CMG5264m; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: 0Linh7tIEtfx Mehmet Tekman writes: >> 3. Please do not use private functions from third-party libraries. I am >> talking about `cl--set-buffer-substring' in particular. >> > > So initially I used `(setf (buffer-substring X Y) new-content)` but I > recieved a warning from Emacs that it was an obsolete generalized > variable. Yup. See https://yhetil.org/emacs-devel/87tu5fzu2r.fsf@localhost/ We need to do things manually. > After some searching I found this entry in an emacs fork used the cl > library: > https://github.com/emacs-citar/citar/commit/809953a2191d0e3217ffbed9270be9b3cd6abfd2 > > Since `(require 'cl-lib)' is already imported in ~ob-tangle.el~, I did > not think it was too taboo to use. Private functions are a subject of change without notice. That's why we do not use them, unless they are _our_ private functions we have control about. > How does one then set the buffer substring? `replace-region-contents'. > Apologies. I rebased and squashed all my commits into one, and then > selectively staged hunks into seperate commits for the git format-patc > process. For some reason the diff function decided that the new > functions should exist right in the middle of an existing function and I > was not sure how to resolve it at the time (though I have a better idea > now). Interactive rebase is helpful. You can also edit, reset files, or apply patches in the middle of rebasing to do extra adjustments. > I will take better care with the messages. I tried to look for previous > "[ANN]" postings in the mailing list that I could emulate, but didn't > pay enough attention it seems. Just try to follow what we usually do in commit messages. See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/ Also, see https://www.gnu.org/prep/standards/html_node/Change-Logs.html and https://git.savannah.gnu.org/cgit/emacs.git/plain/CONTRIBUTE > I'm finally using `gnus' as my mail client so I'm slowly getting into a > more streamlined mindset that should be better at submitting and > formatting patches. (To reply to a mailing list, I do a wide reply to > the author and hope that the `Mail-Followup-To' header is used?) Reply all, or wide reply should be the right way. We do not want to exclude participants who are not subscribed to the mailing list. > Apropos patches: > Given how broken my current patches are, my next set of changes will be > not contingent on the previous ones. I will start a new set of patches. > I hope that's okay. A common approach is changing subject to [PATCH v2] ... You can also use so-called reroll count when generating patchset from git (or magit). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at