From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id +H/uEaQXsWVlBQAAqHPOHw:P1 (envelope-from ) for ; Wed, 24 Jan 2024 14:59:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +H/uEaQXsWVlBQAAqHPOHw (envelope-from ) for ; Wed, 24 Jan 2024 14:59:00 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="mDA/J9GD"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706104740; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=shpATvk1S0+9+so+bRFEnCaioyAstQNKpg/1Ax7iSHs=; b=NmaC9n6OuU/jg39AmjO1ED4s0J3JR9qpCp1NQQ5GIghSHqXA6Jy3VvNKq8G0j8zUWDkOJp RdAnZab0IuDkgmCyIMtl5zexamRIPxE57hFVndr4c2oVyu+CYuKSatQLkCff4ZoRH6Vrkm X2bC3S2TqtIz+t4pAhh31tiIor3VAWwX7UwaoO9P0k80Y+4LCaTeZVT6s9tZBGN+/506ph EEGLWePZ6YHHY8F6Xc5azogB9vIoCz4hB8eXbF9gV3N+yud2lFeE7CiCQd77RGAJ36UONj HryV1gaSoMGJYiz/hcJ7iuk2L0rsvSn18Vsb8EiREC4JgpQ/F0BlT/GfG3tHlw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="mDA/J9GD"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706104740; a=rsa-sha256; cv=none; b=K03+P3/8wzy6AZhGZa87KzDtcJXsKsBPuunaL6wJz2ne3p6UXz5S4/kW/x4VAIxuiSIufi 4+nJjLJ/NeHqG2bysOBHxC9FWXHYNWVUOYEsuEGEIdaKgDks7P3mxBxUWqcNVc7yxwVdxU M8xnGqOlnblXRq0WXa4VgfjZ7v/Bh2c1OzEFsSuS8NsP+BPDBeo6SGHOM1y4Y0Rswh0bN1 bRhksFXiFEJiG1+B37JeguNJZ8u8XFDKlW7NgVOfLUAaIDfZzOo+s+PzUI0hGZm8TEGuin uqgRhJaoPp5p3GQq90WxiBZt0D5f6hEPq8JMyed6bV9fDM0xmN+4pHpRdzPH+A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21B3932207 for ; Wed, 24 Jan 2024 14:59:00 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSdli-0001wL-Pu; Wed, 24 Jan 2024 08:58:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSdlh-0001w9-ST for emacs-orgmode@gnu.org; Wed, 24 Jan 2024 08:58:17 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSdlf-00060d-IZ for emacs-orgmode@gnu.org; Wed, 24 Jan 2024 08:58:17 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BFA53240101 for ; Wed, 24 Jan 2024 14:58:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706104692; bh=shpATvk1S0+9+so+bRFEnCaioyAstQNKpg/1Ax7iSHs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=mDA/J9GDxtMgM/C/cDuwOWJdkeIss8xd7xM31+C6TLFmP3RnBHVWCPOvE2oTmceO/ kyZ9WB+eKZmKo0GYSVl/ukzHqK50JGquB4IAjIJd7AvAlh0gFID/Fhbg+PwGDqtI+3 pYquxwVz/J3d27rL0SIpnBHMHmrceydsJpHFnRBSF/5tjqwnIwmMf2NSavD5EIJpOJ DMt0aNK0LZeGxf/MB3Nii/dG8Ale87xgmY+NQE06skO90DV+Phb+XhsMmTUHWSsasE FPMM71Qx6YGxZlxs4hckCtd5jljMRp5WR9A01VzpCDHrX9dN5O5L4z/k1p2pp610wK RtWrBlkoyAcCg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TKlsb3zp8z6twM; Wed, 24 Jan 2024 14:58:11 +0100 (CET) From: Ihor Radchenko To: Ihor Radchenko Cc: dal-blazej@onenetbeyond.org, emacs-orgmode@gnu.org, jan.seeger@thenybble.de Subject: Re: Bug: org-no-popups disregards display-buffer-fallback-action [9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)] In-Reply-To: <87pmr3mfq3.fsf@localhost> References: <87a6ic5u1c.fsf@dumper.i-did-not-set--mail-host-address--so-tickle-me> <8735o4mhvd.fsf@localhost> <87ilwwvu1g.fsf@onenetbeyond.org> <87pmr3mfq3.fsf@localhost> Date: Wed, 24 Jan 2024 14:01:41 +0000 Message-ID: <87a5ouhltm.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.02 X-Spam-Score: -9.02 X-Migadu-Queue-Id: 21B3932207 X-Migadu-Scanner: mx12.migadu.com X-TUID: LWhwA3sviLHb Ihor Radchenko writes: > dal-blazej@onenetbeyond.org writes: > >> I just inspected the git version. >> >> Is the macro 'org-no-popups' setting _'pop-up-windows' to nil_ and is >> only used by 'org-switch-to-buffer-other-window' that call >> 'switch-to-buffer-other-window' which in turn,=20 >> set _'pop-up-windows' to t_ ? >> >> Also 'pop-up-windows', 'pop-up-frame' are announced to be =C2=AB=C2=A0pr= ovided >> mainly for backward compatibility and should not be used in new code=C2= =A0=C2=BB. > > You are right. org-no-popups was more widely used in the past. It is > probably time to obsolete it and eventually remove it. > > AFAIU, org-no-popups is a legacy function introduced very long time ago. > Is it left there mostly to keep the working code working. I have reviewed all the uses of `org-switch-to-buffer-other-window' - the only user of `org-no-popups' and it looks like the only reason we don't use `switch-to-buffer-other-window' is let-binding `pop-up-frames' to nil. Let-binding `pop-up-windows' is not effective because `switch-to-buffer-other-window' binds (pop-up-windows t). Considering that switching to popup frame is not Emacs default, it can only happen when users deliberately changed display-buffer-alist in their config. Disrespecting user settings is not something nice to do on Org side. I conclude that `org-no-popups' and `org-switch-to-buffer-other-window' should not be used in Org mode. Fixed, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D78dc58508 Other issues raised in this thread need more thought. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at