From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-capture.el: Simplify 'org-capture-get-indirect-buffer'
Date: Mon, 01 Apr 2024 11:46:34 +0000 [thread overview]
Message-ID: <87a5md8fvp.fsf@localhost> (raw)
In-Reply-To: <CH3PR84MB3424CFF9BF4DEE8BCEA65AABC5382@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM>
Morgan Smith <Morgan.J.Smith@outlook.com> writes:
> * lisp/org-capture.el (org-capture-get-indirect-buffer): Simplify by
> using 'generate-new-buffer-name'.
> ...
> - (let ((n 1) (base (buffer-name buffer)) bname)
> - (setq bname (concat prefix "-" base))
> - (while (buffer-live-p (get-buffer bname))
> - (setq bname (concat prefix "-" (number-to-string (cl-incf n)) "-" base)))
> + (let ((bname (generate-new-buffer-name (concat prefix "-" (buffer-name buffer)))))
Thanks, but this is potentially backwards-incompatible.
`generate-new-buffer-name' following a different naming scheme compared
to the current implementation of `org-capture-get-indirect-buffer':
CAPTURE-<NUM>-foo.org vs. CAPTURE-foo.org<N>
Different naming scheme may potentially break user customization in
`display-buffer-alist'.
The change is not justified.
Canceled.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-04-01 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 21:00 [PATCH] lisp/org-capture.el: Simplify 'org-capture-get-indirect-buffer' Morgan Smith
2024-04-01 11:46 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5md8fvp.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Morgan.J.Smith@outlook.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).