emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] byte compile warnings...
Date: Tue, 23 Nov 2010 23:27:06 +0100	[thread overview]
Message-ID: <878w0jfzgl.fsf@Rainer.invalid> (raw)
In-Reply-To: 878w0l14ij.wl%dmaus@ictsoc.de

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi David,

this patch had already been partially applied by Carsten and Eric (in
slightly a different way than I suggested).  The changes to ob.el and
ob-ref.el (the require statements) are therefore superfluous and should
probably be backed out.  There was also a superfluous whitespace change
in org.el (a closing paren that was broken onto the next line).  Patch
to this effect is attached.  You've already cleaned up org-agenda.el and
the conditions in org-macs...

[-- Attachment #2: Cleanup --]
[-- Type: Patch, Size: 1215 bytes --]

From 49e753e1e9c660c4d62fecb2b78b4abea9679026 Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Tue, 23 Nov 2010 23:18:48 +0100
Subject: [PATCH] Keep byte compiler happy

* org.el: remove spurious linebreak introduced by earlier patch
* ob.el, ob-ref.el: remove double fix of the same problem
 lisp/ob-ref.el |    1 -
 lisp/ob.el     |    1 -
 lisp/org.el    |    3 +--
 3 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/lisp/ob-ref.el b/lisp/ob-ref.el
index a8a18ed..f350d61 100644
--- a/lisp/ob-ref.el
+++ b/lisp/ob-ref.el
@@ -51,7 +51,6 @@
 ;;; Code:
 (require 'ob)
-  (require 'org-list)
   (require 'cl))
 (declare-function org-remove-if-not "org" (predicate seq))
diff --git a/lisp/ob.el b/lisp/ob.el
index a7ebdf9..d6e638c 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -30,7 +30,6 @@
 ;;; Code:
-  (require 'org-list)
   (require 'cl))
 (require 'org-macs)
diff --git a/lisp/org.el b/lisp/org.el
index 71e9428..eff4faa 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -72,8 +72,7 @@
   (require 'cl)
-  (require 'gnus-sum)
+  (require 'gnus-sum))
 (require 'calendar)
 (require 'pcomplete)

[-- Attachment #3: Type: text/plain, Size: 320 bytes --]

It was unwise to bundle these fixes into a single patch, I'll put them
into seperate commits should the occasion arise again.

+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:

[-- Attachment #4: Type: text/plain, Size: 201 bytes --]

Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.

  reply	other threads:[~2010-11-23 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 20:37 [PATCH] byte compile warnings Achim Gratz
2010-11-22 20:34 ` David Maus
2010-11-23 22:27   ` Achim Gratz [this message]
2010-12-12 19:17     ` David Maus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878w0jfzgl.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).