* Bug? in the latest revision of org
@ 2011-10-27 19:01 Marcelo de Moraes Serpa
2011-10-28 1:59 ` Paul Sexton
0 siblings, 1 reply; 3+ messages in thread
From: Marcelo de Moraes Serpa @ 2011-10-27 19:01 UTC (permalink / raw)
To: Org Mode
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
Hey list,
Just updated to the latest rev. of org in git. When I try to press <ret>
just in the beginning of a headline in order to move it one line below, I'm
getting this error message:
: Wrong type argument: listp, org-level-1
Any ideas?
Marcelo.
[-- Attachment #2: Type: text/html, Size: 292 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bug? in the latest revision of org
2011-10-27 19:01 Bug? in the latest revision of org Marcelo de Moraes Serpa
@ 2011-10-28 1:59 ` Paul Sexton
2011-10-28 14:43 ` Bastien
0 siblings, 1 reply; 3+ messages in thread
From: Paul Sexton @ 2011-10-28 1:59 UTC (permalink / raw)
To: emacs-orgmode
Marcelo de Moraes Serpa <celoserpa <at> gmail.com> writes:
>
> Hey list,Just updated to the latest rev. of org in git. When I try to press
<ret> just in the beginning of a headline in order to move it one line below,
I'm getting this error message:: Wrong type argument: listp, org-level-1Any
ideas?Marcelo.
Yes, it's a bug - I was just about to post about it myself.
The problem is in the recent change to the 'org-return' function in org.el.
(commit de8cd8ee41543bb0548af1cdc7fa7a8168321677 on 26 Oct).
The original code was:
((and org-return-follows-link
(eq (get-text-property (point) 'face) 'org-link))
The commit changed it to:
((and org-return-follows-link
(or (eq (get-text-property (point) 'face) 'org-link)
(memq 'org-link (get-text-property (point) 'face))))
But this breaks if there is a single face at point that is not org-link,
because in that case the text property at point will not be a list,
and this will cause an error when it is given as the second argument
to memq.
The code needs to change to something like:
((and org-return-follows-link
(let ((tprop (get-text-property (point) 'face)))
(or (eq tprop 'org-link)
(and (listp tprop) (memq 'org-link tprop)))))
Paul.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Bug? in the latest revision of org
2011-10-28 1:59 ` Paul Sexton
@ 2011-10-28 14:43 ` Bastien
0 siblings, 0 replies; 3+ messages in thread
From: Bastien @ 2011-10-28 14:43 UTC (permalink / raw)
To: Paul Sexton; +Cc: emacs-orgmode
Hi Paul,
Paul Sexton <psexton.2a@gmail.com> writes:
> The code needs to change to something like:
>
> ((and org-return-follows-link
> (let ((tprop (get-text-property (point) 'face)))
> (or (eq tprop 'org-link)
> (and (listp tprop) (memq 'org-link tprop)))))
thanks for the analysis and the fix -- I committed it right
now. And thanks to Marcelo for the report !
--
Bastien
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-28 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-27 19:01 Bug? in the latest revision of org Marcelo de Moraes Serpa
2011-10-28 1:59 ` Paul Sexton
2011-10-28 14:43 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).