From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Luis Anaya <papoanaya@hotmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org mode export to Groff MM. Feature Freeze
Date: Thu, 19 Jul 2012 17:33:36 +0200 [thread overview]
Message-ID: <878vefbwa7.fsf@gmail.com> (raw)
In-Reply-To: <BLU0-SMTP387C201EDE728F2F5787474B7DA0@phx.gbl> (Luis Anaya's message of "Tue, 17 Jul 2012 20:04:03 -0400")
Hello,
It sure looks interesting.
Here are a few comment about org-e-man.el.
1. Please do not leave trailing parenthesis (i.e at line 228).
2. You can remove every `declare-function'. You only need to
(require 'org-export)
in the file header, actually.
3. You can remove `org-e-man-babel-language-alist' variable and
`org-e-man--guess-babel-language' function since they are specific to
the "babel" LaTeX package.
4. For the same reason, you can remove `org-e-man--guess-inputenc'
("inputenc" LaTeX package).
5. Do you really need something as complicated as `org-e-man-classes'?
It is a chore to use in `e-latex' but is tolerated since it allows
for much configurability, but in a man exporter, I doubt it is worth
introducing it. Indeed, I don't think there are much packages and
section configurations to play with.
6. You shouldn't ignore drawers. Simply return their contents with no
additional syntax. I.e.
(defun org-e-man-drawer (drawer contents info)
"Blah..."
contents)
In that case, you can safely remove unused
`org-e-man-format-drawer-function' variable.
7. Something is wrong in `org-e-man-entity'. There is no `:man' format
for entities. You can choose among `:latex', `ascii', `:html',
`:latin1' or `:utf-8'.
8. Since there is no image support in man, you can remove unused
variables `org-e-man-image-default-option',
`org-e-man-default-figure-position', `org-e-man-inline-image-rules'.
9. `org-e-man--make-option-string' looks unused too. You may remove it.
10. Line 1743: (if (not (null attr-item))...) => (if attr-item ...)
11. I think that you can hard-code text markup macros and remove
`org-e-man-text-markup-alist'. It will simplify code in
`org-e-man--text-markup'.
12. Optionally, `org-e-man-headline' can probably be simplified a lot
too. I imagine that someone using the man exporter doesn't expect
much configuration for headlines.
13. In `org-e-man-plain-list', it looks like you can simply return
contents (as for drawers) and remove everything else. Same for
special blocks. Just return contents.
By the way (format "%s" contents) is exactly `contents' since this
argument is always a string.
14. In general, try to remove as much unused stuff as possible.
Thank you for your work,
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2012-07-19 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.99.1342454425.6558.emacs-orgmode@gnu.org>
2012-07-16 16:38 ` Org mode export to Groff MM. Feature Freeze Luis Anaya
2012-07-16 17:06 ` Bastien
2012-07-16 17:20 ` Nicolas Goaziou
2012-07-16 18:35 ` Luis Anaya
2012-07-16 20:36 ` Nicolas Goaziou
2012-07-16 21:22 ` Luis Anaya
2012-07-17 1:35 ` Luis Anaya
2012-07-17 7:50 ` Nicolas Goaziou
2012-07-17 8:53 ` Luis Anaya
[not found] ` <BLU0-SMTP243814C6971CC983CEECAFBB7D40@phx.gbl>
2012-07-16 17:42 ` FW: " Luis Anaya
2012-07-16 20:18 ` Bastien
2012-07-17 1:56 ` Avdi Grimm
2012-07-17 2:50 ` Luis Anaya
2012-07-17 10:20 ` Nicolas Goaziou
2012-07-17 14:06 ` Luis Anaya
2012-07-17 18:08 ` Luis Anaya
2012-07-18 0:04 ` Luis Anaya
2012-07-18 1:23 ` Suvayu Ali
2012-07-19 15:33 ` Nicolas Goaziou [this message]
2012-07-19 19:09 ` Luis Anaya
2012-07-20 0:07 ` Luis Anaya
2012-07-20 1:46 ` Luis Anaya
2012-07-17 2:53 ` Luis Anaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vefbwa7.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=papoanaya@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).