From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH 07/10] Simplify org-babel-execute-src-block Date: Tue, 02 Apr 2013 21:41:26 +0200 Message-ID: <878v50u3dl.fsf@Rainer.invalid> References: <1364794944-13826-1-git-send-email-aaronecay@gmail.com> <1364794944-13826-8-git-send-email-aaronecay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:33801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN75S-0005vS-2O for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 15:41:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UN75Q-0007eX-RU for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 15:41:41 -0400 Received: from plane.gmane.org ([80.91.229.3]:39333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN75Q-0007eN-L8 for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 15:41:40 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UN75m-0007Ne-P3 for emacs-orgmode@gnu.org; Tue, 02 Apr 2013 21:42:02 +0200 Received: from pd9eb3d42.dip.t-dialin.net ([217.235.61.66]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 02 Apr 2013 21:42:02 +0200 Received: from Stromeko by pd9eb3d42.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 02 Apr 2013 21:42:02 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > * lisp/ob-core.el (org-babel-execute-src-block): Simplify control flow > > Avoid potential duplication of org-babel-process-params call. Also > makes the code simpler. You may be changing semantics here. I'm not entirely certain if the current way of dealing with the the unmerged and merged parameters and the info block is necessary, but I'd be wary of such a change. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables