From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: Gentoo ebuild for app-emacs/org-mode-8.0.1 Date: Tue, 23 Apr 2013 19:17:16 +0200 Message-ID: <878v49tbdv.fsf@Rainer.invalid> References: <51744553.3050407@web.de> <87d2tmzdjj.fsf@Rainer.invalid> <51767866.7060708@web.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:45926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUgqN-0004tM-Id for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 13:17:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUgqL-0003Z3-Oy for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 13:17:27 -0400 Received: from plane.gmane.org ([80.91.229.3]:44896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUgqL-0003Yh-Hj for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 13:17:25 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UUgqK-0004Ks-NE for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 19:17:24 +0200 Received: from pd9eb085d.dip0.t-ipconnect.de ([217.235.8.93]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Apr 2013 19:17:24 +0200 Received: from Stromeko by pd9eb085d.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 23 Apr 2013 19:17:24 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Christoph LANGE writes: > thanks for your improvement suggestions! Before I put this into > practice, let me ask some questions. I am neither an expert in > distributing Org nor in writing ebuilds yet. > > 2013-04-22 18:21 Achim Gratz: >>> ELISP_REMOVE="lisp/org-install.el" >> >> You'll also want to remove org-loaddefs.el and org-version.el. > > Why? Because they will automatically be re-generated during "make > install", or because they are not necessary unless installing from git? Yes, because they are auto-generated. In fact you might want to clear the whole installation tree to remove files from earlier versions of Org that have been renamed. >>> elisp-install ${PN}/contrib contrib/lisp/*org*.el || die >> >> This is wrong if you use ORG_ADD_CONTRIB. These files are already taken >> care of by "make install" > > OK, which means that I can remove that "elisp-install" line? I'd think so, but I don't know the exact details of how ebuild works. >> and contrib should not be added to the load-path > > Why not? Note that this is conditional on the use flag "contrib". So > in this case the user has explicitly decided "I want the contributed > features". Then your ebuild file is likely defective, since your definition of ORG_ADD_CONTRIB doesn't seem to be conditional. >> (it also shouldn't exist as a subdirectory under ${PN}). > > Where should it go instead, if anywhere? Nowhere, the installation includes all the files that you added with ORG_ADD_CONTRIB right where Org gets installed. Adding them again (uncompiled) in a different place is asking for trouble. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf rackAttack: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds