emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: Gentoo ebuild for app-emacs/org-mode-8.0.1
Date: Tue, 23 Apr 2013 19:17:16 +0200	[thread overview]
Message-ID: <878v49tbdv.fsf@Rainer.invalid> (raw)
In-Reply-To: <51767866.7060708@web.de>

Christoph LANGE writes:
> thanks for your improvement suggestions!  Before I put this into
> practice, let me ask some questions.  I am neither an expert in
> distributing Org nor in writing ebuilds yet.
>
> 2013-04-22 18:21 Achim Gratz:
>>> ELISP_REMOVE="lisp/org-install.el"
>>
>> You'll also want to remove org-loaddefs.el and org-version.el.
>
> Why?  Because they will automatically be re-generated during "make
> install", or because they are not necessary unless installing from git?

Yes, because they are auto-generated.  In fact you might want to clear
the whole installation tree to remove files from earlier versions of Org
that have been renamed.

>>> 		elisp-install ${PN}/contrib contrib/lisp/*org*.el || die
>>
>> This is wrong if you use ORG_ADD_CONTRIB.  These files are already taken
>> care of by "make install"
>
> OK, which means that I can remove that "elisp-install" line?

I'd think so, but I don't know the exact details of how ebuild works.

>> and contrib should not be added to the load-path
>
> Why not?  Note that this is conditional on the use flag "contrib".  So
> in this case the user has explicitly decided "I want the contributed
> features".

Then your ebuild file is likely defective, since your definition of
ORG_ADD_CONTRIB doesn't seem to be conditional.

>> (it also shouldn't exist as a subdirectory under ${PN}).
>
> Where should it go instead, if anywhere?

Nowhere, the installation includes all the files that you added with
ORG_ADD_CONTRIB right where Org gets installed.  Adding them again
(uncompiled) in a different place is asking for trouble.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

  reply	other threads:[~2013-04-23 17:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-21 20:00 Christoph LANGE
2013-04-22 16:48 ` Jay Kerns
2013-04-22 17:04   ` John Hendy
2013-04-23 11:54     ` Christoph LANGE
2013-04-22 17:21 ` Achim Gratz
2013-04-23 12:02   ` Christoph LANGE
2013-04-23 17:17     ` Achim Gratz [this message]
2013-05-03 13:03       ` Christoph LANGE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v49tbdv.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: Gentoo ebuild for app-emacs/org-mode-8.0.1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).