From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daimrod Subject: Re: [PATCH] org-contacts: Update contacts cache if it contains markers with no buffer Date: Sat, 20 Jul 2013 17:22:55 +0200 Message-ID: <878v11cl2o.fsf@tanger.home> References: <878v1cdoke.fsf.rednorrock@ifi.uio.no> <87fvvexvtl.fsf@tanger.home> <87zjtlwsbw.fsf.rednorrock@ifi.uio.no> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0YvA-0003h5-SE for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 11:18:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0Yv9-0003A7-K8 for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 11:18:08 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:54091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Yv9-00039R-CH for emacs-orgmode@gnu.org; Sat, 20 Jul 2013 11:18:07 -0400 Received: by mail-wg0-f42.google.com with SMTP id z11so1250885wgg.5 for ; Sat, 20 Jul 2013 08:18:06 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: =?utf-8?Q?=C3=98yvind?= Stegard Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =C3=98yvind Stegard writes: > Daimrod writes: > > [...] > >> Thanks for the bug report! >> >> Don't you think that checking if one of the buffer would be enough and >> faster? >> With something like (every #'get-file-buffer org-contacts-files) > > Hi, > > I thought about that, yes. But what about when an org-contacts buffer is > killed and subsequently re-opened (like using `find-alternate-file' with > same file name). Then the buffer will exist for the file, but it will be > a new instance, and the markers in org-contacts-db will still be dead. > That's why I decided to just check the markers instead. You're right, good catch! I've installed the patch and haven't felt any slowdown, but I've a small contacts file. If people complain about slowdown we could add a buffer local hook to ask before killing contacts files. > Regards, > > =C3=98yvind =2D-=20 Daimrod/Greg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR6qtPAAoJEBNzVHcrZRiUFJMQAJDTwpiStA9ZcVqQQ5sPl1pQ QXQoAOwGFbnaiifxiS++o1ynMXnVOakST6+d77hD1E0M0gJZIFe2uphGBEljTK0E oz74+Wk+EqUstMXpCiEZPA7i9bA86pmEGWsZa+i5fBKhzQs1dBS9Ct0PNB2F+7aV NUYzk2HjacAJ9M1vaEoj+tIkQOJqAqp1MmX3Tjm+g8nXm7tY4nME8h/DADtBkWNX d9APS3t3XkJms80efVgGw0csaWrZvFHY4EDXVO5MUIfg5CyMBJ0MuqlAONjd4RtF tPF8lDmDNAkxdl0mqEqG2K5rB1o1CeDe5pxEVGd8RhbtW5jfVnpLINDk3m1Tr/n+ FNb7iOayj/rTggcSSlpMZVSbPO+i8dtUmCDzqX6XINDT5o6mFPR1lp0MitJbpfW4 OeQjCwPBnjmj+LJJ2VIUbXYD75Hqr382DG3bfIZPbbVylsAFI1ndU5iY1eIcenXW W7UgiBxyym1NqTmUzgWUNHb5Z5pwnVL/NhP+0bT8/rJXej3+dbkjhsYsn5axwvZC dNAbYvmW8mbeyWuLoWfu4h1aU0Q84X0V5xZ4o7G+Mw83kYs8pNDxBdF5q88KdDtI H2ojcOhRZC0luF48KVVEMU4Hlg91gEwHbkdzaTBsYGAp+6KiB/e0+g1sacMpJx6G N89IVP9tArD+W/JR0XJd =H07g -----END PGP SIGNATURE----- --=-=-=--