From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [babel][PATCHES] exporting inline source code Date: Sun, 22 Jun 2014 00:02:33 -0400 Message-ID: <878uopbnhi.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyYzW-0000o7-Rx for emacs-orgmode@gnu.org; Sun, 22 Jun 2014 00:03:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WyYzN-0006M8-Qm for emacs-orgmode@gnu.org; Sun, 22 Jun 2014 00:02:54 -0400 Received: from mail-qa0-x236.google.com ([2607:f8b0:400d:c00::236]:61249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyYzN-0006LW-BW for emacs-orgmode@gnu.org; Sun, 22 Jun 2014 00:02:45 -0400 Received: by mail-qa0-f54.google.com with SMTP id v10so4543801qac.13 for ; Sat, 21 Jun 2014 21:02:35 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Berthier , emacs-orgmode@gnu.org Hi Nicolas, These both seem like good patches to me. Did you run the test suite to make sure that no tests are broken by them? It would also be good if you added some tests for this functionality =E2=80=93 the example included = at the bottom of your email is a good starting point. The other babel export tests live in the file testing/lisp/test-ob-exp.el, so that=E2=80=99= s the spot to look for examples. Have you heard back from the FSF about your copyright assignment? Thanks for the patches, --=20 Aaron Ecay