emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Aaron Ecay <aaronecay@gmail.com>
To: Nicolas Berthier <nberth@member.fsf.org>, emacs-orgmode@gnu.org
Subject: Re: [babel][PATCHES] exporting inline source code
Date: Sun, 22 Jun 2014 00:02:33 -0400	[thread overview]
Message-ID: <878uopbnhi.fsf@gmail.com> (raw)
In-Reply-To: <vp0o4mzou2wf.fsf@epicea.irisa.fr>

Hi Nicolas,

These both seem like good patches to me.  Did you run the test suite to
make sure that no tests are broken by them?  It would also be good if
you added some tests for this functionality – the example included at
the bottom of your email is a good starting point.  The other babel
export tests live in the file testing/lisp/test-ob-exp.el, so that’s the
spot to look for examples.

Have you heard back from the FSF about your copyright assignment?

Thanks for the patches,

-- 
Aaron Ecay

next prev parent reply	other threads:[~2014-06-22  4:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 17:37 [babel][PATCHES] exporting inline source code Nicolas Berthier
2014-06-22  4:02 ` Aaron Ecay [this message]
2014-07-27 17:23   ` Bastien
2014-07-29  7:40     ` Nicolas Berthier
2014-07-29 13:19       ` Bastien
2014-07-30 16:06         ` Nicolas Berthier
2014-07-30 19:26           ` Nicolas Goaziou
2014-07-30 20:01             ` Achim Gratz
2014-07-30 20:23               ` Nicolas Goaziou
2014-08-01 12:23             ` Nicolas Berthier
2014-08-22 12:47               ` Nicolas Goaziou
2014-08-22 13:32                 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878uopbnhi.fsf@gmail.com \
    --to=aaronecay@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nberth@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).