emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [RFC] Display most recent log item in Agenda
Date: Sun, 14 Dec 2014 21:34:34 +0100	[thread overview]
Message-ID: <878uia6kdh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87388imto5.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 14 Dec 2014 18:07:06 +0800")

Hello,

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Undeterred by my previous bum patch, I'm sending more patches!
>
> Most of these are "what do you think" patches.
>
> 1. Ensure-org-log-into-drawer-returns-nil-or-string
>
> If the answer to my last question is "make sure `org-log-into-drawer'
> never returns just t", then this patch does that. If that isn't the
> answer, something can be done with `org-log-beginning'.

I applied something similar. Thank you.

> 2. Missing-comma-in-org-agenda-with-point-at-orig-entry
>
> The (currently unused) macro `org-agenda-with-point-at-orig-entry' is
> missing a comma.
>
> 3. New-function-org-get-log-list and
> New-function-org-agenda-show-log-item
>
> This is the "what do you think part". The first patch finds and returns
> the state log items of the current entry, as a list of parsed elements.
> It probably doesn't try hard enough to make sure it's really found the
> list.
>
> The second implements an Agenda command which displays the text of the
> most recent note on the entry under point. I use logging a lot, and am
> forever looking at "WAIT" or "NEXT" todos, and wondering what the heck I
> was waiting for, or actually supposed to do next.
>
> If this is acceptable in principle, the finished product would probably
> be a normal org-mode function, with an Agenda implementation on top of
> that, and maybe some sort of guard against displaying overly-long
> notes.

[...]

> WDYT?

I think the feature is interesting. However, the implementation seems
inefficient. Why do you need to parse all log entries if all you're
interested in is the last one? Parsing the last one should be
sufficient.

Better, you could store the last note as a text property on the headline
and skip altogether the parsing phase.

WDYT?


Regards,

-- 
Nicolas Goaziou

  parent reply	other threads:[~2014-12-14 20:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-14 10:07 [RFC] Display most recent log item in Agenda Eric Abrahamsen
2014-12-14 15:12 ` Eric Abrahamsen
2014-12-14 20:34 ` Nicolas Goaziou [this message]
2014-12-15  1:34   ` Eric Abrahamsen
2014-12-15 12:43     ` Nicolas Goaziou
2014-12-16  2:26       ` Eric Abrahamsen
2014-12-16  9:10         ` Nicolas Goaziou
2014-12-17  7:16           ` Eric Abrahamsen
2014-12-20 21:13             ` Nicolas Goaziou
2014-12-19  8:50           ` Eric Abrahamsen
2014-12-20 21:02             ` Nicolas Goaziou
2014-12-21  4:08               ` Eric Abrahamsen
2014-12-15  4:29   ` Eric Abrahamsen
2014-12-15 12:33     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878uia6kdh.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).