From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [RFC] Display most recent log item in Agenda
Date: Sat, 20 Dec 2014 22:02:19 +0100 [thread overview]
Message-ID: <878ui2yqzo.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871tnwnhu4.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 19 Dec 2014 16:50:59 +0800")
Hello,
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> I keep hammering on this but... There's still a bug in
> `org-log-beginning', I think maybe the same one as before. Say it's
> called on an empty entry, or one that only contains a property drawer
> and/or a planning line, and there's another entry immediately after it,
> no blank line. Then we reach this line:
>
> (if (org-at-heading-p) (point)
>
> The test returns true because we're already on the next headline.
> (point) is returned as the place to put the new note, without checking
> if a drawer should be inserted, too. That means the first note won't go
> in a drawer, but all subsequent ones do.
>
> I came up with something that works, but I look forward to seeing a more
> elegant solution!
You're right. Thanks for the patch. I applied something slightly
different, however.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-12-20 21:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 10:07 [RFC] Display most recent log item in Agenda Eric Abrahamsen
2014-12-14 15:12 ` Eric Abrahamsen
2014-12-14 20:34 ` Nicolas Goaziou
2014-12-15 1:34 ` Eric Abrahamsen
2014-12-15 12:43 ` Nicolas Goaziou
2014-12-16 2:26 ` Eric Abrahamsen
2014-12-16 9:10 ` Nicolas Goaziou
2014-12-17 7:16 ` Eric Abrahamsen
2014-12-20 21:13 ` Nicolas Goaziou
2014-12-19 8:50 ` Eric Abrahamsen
2014-12-20 21:02 ` Nicolas Goaziou [this message]
2014-12-21 4:08 ` Eric Abrahamsen
2014-12-15 4:29 ` Eric Abrahamsen
2014-12-15 12:33 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ui2yqzo.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).