From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix `org-refresh-category-properties' Date: Tue, 28 Apr 2015 09:42:55 +0200 Message-ID: <878udcsnpc.fsf@nicolasgoaziou.fr> References: <87386sitvl.fsf@konixwork.incubateur.ens-lyon.fr> <87egqcr6hb.fsf@nicolasgoaziou.fr> <874mo0g2wx.fsf@konixwork.incubateur.ens-lyon.fr> <871tj4g2gw.fsf@konixwork.incubateur.ens-lyon.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn09F-0000tW-VA for emacs-orgmode@gnu.org; Tue, 28 Apr 2015 03:41:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yn09B-00025F-Dr for emacs-orgmode@gnu.org; Tue, 28 Apr 2015 03:41:41 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:53685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yn09B-00024H-7q for emacs-orgmode@gnu.org; Tue, 28 Apr 2015 03:41:37 -0400 In-Reply-To: <871tj4g2gw.fsf@konixwork.incubateur.ens-lyon.fr> (Samuel Loury's message of "Tue, 28 Apr 2015 09:02:23 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Samuel Loury Cc: OrgMode ML Hello, Samuel Loury writes: > Samuel Loury writes: > >> Dear Nicolas, > > [...] > >> --8<---------------cut here---------------start------------->8--- >> #+CATEGORY: c >> * foo >> :PROPERTIES: >> :CATEGORY: a >> :END: >> ** bar >> :PROPERTIES: >> :CATEGORY: b >> :END: >> >> --8<---------------cut here---------------end--------------->8--- >> >> `org-get-category' in the bar headline returns 'a', while I would expect >> it to return 'b'. > > [...] > >> I don't understand why one would want to remove this behavior. Does it >> raise a technical issue? No, it's a bug. > After a quick look at the code, I wonder if this new behavior is a > technical choice or hopefully a simple mistake. The latter. > Please find attached a patch that restores the behavior of taking into > account the CATEGORY keyword in sub-trees also. Applied, with an additional test. Thank you. Regards, -- Nicolas Goaziou