emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Org-mode <emacs-orgmode@gnu.org>
Subject: [PATCH] org-src: Fix reference to free variable
Date: Sat, 23 May 2015 15:30:58 -0400	[thread overview]
Message-ID: <878ucfozv1.fsf@kmlap.domain.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Hello,

The attached patch fixes a void variable error that occurs when remote
editing an empty footnote.  (This was introduced by commit
71641bc3a08.)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-src-Fix-reference-to-free-variable.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

From 9ba6a2f4af05c1104c678d959ff285bc7df5a70a Mon Sep 17 00:00:00 2001
From: Kyle Meyer <kyle@kyleam.com>
Date: Sat, 23 May 2015 15:18:07 -0400
Subject: [PATCH] org-src: Fix reference to free variable

* lisp/org-src.el (org-src--contents-area): Replace a let with let*.
---
 lisp/org-src.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/org-src.el b/lisp/org-src.el
index 5201dca..88c8dd2 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -273,10 +273,10 @@ (defun org-src--contents-area (datum)
   (let ((type (org-element-type datum)))
     (cond
      ((eq type 'footnote-definition)
-      (let ((beg (org-with-wide-buffer
-		  (goto-char (org-element-property :post-affiliated datum))
-		  (search-forward "]")))
-	    (end (or (org-element-property :contents-end datum) beg)))
+      (let* ((beg (org-with-wide-buffer
+		   (goto-char (org-element-property :post-affiliated datum))
+		   (search-forward "]")))
+	     (end (or (org-element-property :contents-end datum) beg)))
 	(list beg end (buffer-substring-no-properties beg end))))
      ((org-element-property :contents-begin datum)
       (list (org-element-property :contents-begin datum)
-- 
2.4.1


[-- Attachment #3: Type: text/plain, Size: 9 bytes --]


--
Kyle

next             reply	other threads:[~2015-05-23 19:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23 19:30 Kyle Meyer [this message]
2015-05-23 19:53 ` [PATCH] org-src: Fix reference to free variable Nicolas Goaziou

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:5201dca dfblob:88c8dd2
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ucfozv1.fsf@kmlap.domain.org \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).