From: Kosyrev Serge <_deepfire@feelingofgreen.ru>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH 7/8] ox-taskjuggler.el: allow 'priority' to be a directly-specified integer
Date: Tue, 10 Nov 2015 11:26:05 +0300 [thread overview]
Message-ID: <878u66jm5e.fsf_-_@feelingofgreen.ru> (raw)
In-Reply-To: <87bnb2soei.fsf@gmail.com> (sfid-20151110_033548_881549_A7E97F8F) (Aaron Ecay's message of "Tue, 10 Nov 2015 00:12:37 +0000")
Aaron Ecay <aaronecay@gmail.com> writes:
> 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>>
>> * ox-taskjuggler.el (org-taskjuggler--build-task): fix priority specification
>> by allowing it to be directly passed down, in case it parses as an integer.
>> ---
>> contrib/lisp/ox-taskjuggler.el | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
>> index 44ffeb6..d49db62 100644
>> --- a/contrib/lisp/ox-taskjuggler.el
>> +++ b/contrib/lisp/ox-taskjuggler.el
>> @@ -875,10 +875,16 @@ a unique id will be associated to it."
>> (org-taskjuggler-get-end task))
>> (org-element-property :PERIOD task)))))
>> (priority
>> - (let ((pri (org-element-property :priority task)))
>> + (let ((pri (org-element-property :PRIORITY task)))
>> (and pri
>> - (max 1 (/ (* 1000 (- org-lowest-priority pri))
>> - (- org-lowest-priority org-highest-priority)))))))
>> + ;; The exported task priority can be either specified
>> + ;; via the Org priority mechahism (which is currently broken),
>
> Can you say more about what breakage you mean? Is it something that can
> be easily fixed?
Perhaps I was unclear in this message -- it's not the Org's priority
mechanism that is broken, it's the way ox-taskjuggler uses it that is.
Org specifies priorities via a list of enums, whereas TJ expects an
integer in the range 0-1000.
The quoted little piece of math in ox-taskjuggler tried to provide a
mapping, but failed and I couldn't figure out how to make it work --
mainly because I couldn't understand how it was /supposed/ to work.
Hence I made a shortcut.
--
с уважениeм / respectfully,
Косырев Сергей
next prev parent reply other threads:[~2015-11-10 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 10:20 [PATCH 7/8] ox-taskjuggler.el: allow 'priority' to be a directly-specified integer Kosyrev Serge
2015-11-10 0:12 ` Aaron Ecay
2015-11-10 8:26 ` Kosyrev Serge [this message]
2015-11-11 2:31 ` Aaron Ecay
-- strict thread matches above, loose matches on Subject: below --
2015-11-08 10:20 Kosyrev Serge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u66jm5e.fsf_-_@feelingofgreen.ru \
--to=_deepfire@feelingofgreen.ru \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).