emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Phil Hudson <phil.hudson@iname.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-agenda-bulk-custom-functions Customize mismatch
Date: Tue, 10 May 2016 23:34:37 +0200	[thread overview]
Message-ID: <878tzhk36a.fsf@saiph.selenimh> (raw)
In-Reply-To: <87mvo0irem.fsf@quiz.hudson-it.ddns.net> (Phil Hudson's message of "Sun, 08 May 2016 14:57:21 +0100")

Hello,

Phil Hudson <phil.hudson@iname.com> writes:

> The first approach is supported by defcustom and gives us the chance to
> be both more descriptive and more prescriptive. It shouldn't break
> anything that isn't in fact already broken.
>
> The second approach is as simple as changing that `cadr` to a `cdr`, but
> it does risk breaking working configs where the alist was populated
> procedurally.
>
> I propose the first. Here's a patch.

Looks good. Thank you.

Could you send it using "git format-patch". Also, could you provide an
appropriate commit message? See
<http://orgmode.org/worg/org-contribute.html> for details.

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2016-05-10 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-08 13:57 org-agenda-bulk-custom-functions Customize mismatch Phil Hudson
2016-05-10 21:34 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tzhk36a.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=phil.hudson@iname.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).