* Bug: Properties don't work in clocktable [9.0.5 (release_9.0.5-305-g21797c @ /Users/dale/.emacs.d/el-get/org-mode/lisp/)]
@ 2017-02-18 17:06 Dale
2017-02-18 20:02 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Dale @ 2017-02-18 17:06 UTC (permalink / raw)
To: emacs-orgmode
For me, clocktable's :properties option is including columns for the
properties, but is never including the actual values for those properties.
This *may* be a bug, specifically in org-clock.el line 2590:
(pcase-dolist (`(,level ,headline ,ts ,time . ,props) entries)
...)
I believe the ". ,props" should be just ",props", since I think the list
of properties here is its own list, and not the cdr of entries:
(pcase-dolist (`(,level ,headline ,ts ,time ,props) entries)
...)
To reproduce this problem using org-mode HEAD, evaluate the following:
(switch-to-buffer (generate-new-buffer "*org mode test*"))
(org-mode)
(insert "* Time
:PROPERTIES:
:FOO: bar
:END:
:LOGBOOK:
CLOCK: [2017-02-18 Sat 10:50]--[2017-02-18 Sat 10:51] => 0:01
:END:
#+BEGIN: clocktable :compact t :properties (\"FOO\") :maxlevel 2
:scope subtree
#+END:
")
(goto-char (point-max))
(forward-line -1)
(org-dblock-update)
Expected result which includes the property value:
#+BEGIN: clocktable :compact t :properties ("FOO") :maxlevel 2 :scope subtree
#+CAPTION: Clock summary at [2017-02-18 Sat 10:59]
| FOO | Headline | Time |
|-----+--------------+---------|
| | *Total time* | *0.02h* |
|-----+--------------+---------|
| bar | Time | 0.02h |
#+END:
Observed result from HEAD, note no property value:
#+BEGIN: clocktable :compact t :properties ("FOO") :maxlevel 2 :scope subtree
#+CAPTION: Clock summary at [2017-02-18 Sat 10:54]
| FOO | Headline | Time |
|-----+--------------+---------|
| | *Total time* | *0.02h* |
|-----+--------------+---------|
| | Time | 0.02h |
#+END:
Emacs : GNU Emacs 25.2.1 (x86_64-apple-darwin15.6.0, Carbon Version
157 AppKit 1404.47)
of 2017-02-07
Package: Org mode version 9.0.5 (release_9.0.5-305-g21797c @
/Users/dale/.emacs.d/el-get/org-mode/lisp/)
I'll take every opportunity I can to thank all the people who work to
make org-mode so indispensable! Thank you!
Dale
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: Properties don't work in clocktable [9.0.5 (release_9.0.5-305-g21797c @ /Users/dale/.emacs.d/el-get/org-mode/lisp/)]
2017-02-18 17:06 Bug: Properties don't work in clocktable [9.0.5 (release_9.0.5-305-g21797c @ /Users/dale/.emacs.d/el-get/org-mode/lisp/)] Dale
@ 2017-02-18 20:02 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-02-18 20:02 UTC (permalink / raw)
To: Dale; +Cc: emacs-orgmode
Hello,
Dale <dale@codefu.org> writes:
> For me, clocktable's :properties option is including columns for the
> properties, but is never including the actual values for those properties.
> This *may* be a bug, specifically in org-clock.el line 2590:
>
> (pcase-dolist (`(,level ,headline ,ts ,time . ,props) entries)
> ...)
>
> I believe the ". ,props" should be just ",props", since I think the list
> of properties here is its own list, and not the cdr of entries:
>
> (pcase-dolist (`(,level ,headline ,ts ,time ,props) entries)
> ...)
>
> To reproduce this problem using org-mode HEAD, evaluate the following:
>
> (switch-to-buffer (generate-new-buffer "*org mode test*"))
> (org-mode)
> (insert "* Time
> :PROPERTIES:
> :FOO: bar
> :END:
> :LOGBOOK:
> CLOCK: [2017-02-18 Sat 10:50]--[2017-02-18 Sat 10:51] => 0:01
> :END:
>
> #+BEGIN: clocktable :compact t :properties (\"FOO\") :maxlevel 2
> :scope subtree
>
> #+END:
> ")
> (goto-char (point-max))
> (forward-line -1)
> (org-dblock-update)
>
> Expected result which includes the property value:
>
> #+BEGIN: clocktable :compact t :properties ("FOO") :maxlevel 2 :scope subtree
> #+CAPTION: Clock summary at [2017-02-18 Sat 10:59]
>
> | FOO | Headline | Time |
> |-----+--------------+---------|
> | | *Total time* | *0.02h* |
> |-----+--------------+---------|
> | bar | Time | 0.02h |
> #+END:
>
> Observed result from HEAD, note no property value:
>
> #+BEGIN: clocktable :compact t :properties ("FOO") :maxlevel 2 :scope subtree
> #+CAPTION: Clock summary at [2017-02-18 Sat 10:54]
>
> | FOO | Headline | Time |
> |-----+--------------+---------|
> | | *Total time* | *0.02h* |
> |-----+--------------+---------|
> | | Time | 0.02h |
> #+END:
You're right. Fixed. Thank you.
For my own redemption, I added regression tests.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-18 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-18 17:06 Bug: Properties don't work in clocktable [9.0.5 (release_9.0.5-305-g21797c @ /Users/dale/.emacs.d/el-get/org-mode/lisp/)] Dale
2017-02-18 20:02 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).