emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Adam Porter <adam@alphapapa.net>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add option to automatically align tags in agenda view
Date: Mon, 07 Aug 2017 18:04:42 -0400	[thread overview]
Message-ID: <878tivt4p1.fsf@kyleam.com> (raw)
In-Reply-To: <87k22fnr3o.fsf@alphapapa.net>

Adam Porter <adam@alphapapa.net> writes:

> Ok, I've updated the patch.

Thanks.  A few more comments.

> (org-agenda-align-tags): Handle automatic alignment
> (org-agenda-tags-column): Add 'auto setting

You're missing the file name in the entries above.  Also, the entries
should end in a period.

> -(defcustom org-agenda-tags-column -80
> +(defcustom org-agenda-tags-column 'auto
>    "Shift tags in agenda items to this column.
> -If this number is positive, it specifies the column.  If it is negative,
> -it means that the tags should be flushright to that column.  For example,
> --80 works well for a normal 80 character screen."
> +If set to `auto', tags will be automatically aligned to the right
> +edge of the window.
> +
> +If set to a positive number, tags will be left-aligned to that
> +column.  If set to a negative number, tags will be right-aligned
> +to that column.  For example, -80 works well for a normal 80
> +character screen."
>    :group 'org-agenda-line-format
> -  :type 'integer)
> +  :type '(choice
> +	  (const :tag "Automatically align to right edge of window" auto)
> +	  (integer :tag "Specific column" -80)))

Since you're changing the default value, shouldn't you add appropriate
values for the :version and :package-version keywords?

It'd be good to mention this change in ORG-NEWS as well.

-- 
Kyle

next prev parent reply	other threads:[~2017-08-07 22:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 13:56 [PATCH] Add option to automatically align tags in agenda view Adam Porter
2017-08-07 17:32 ` Kyle Meyer
2017-08-07 18:57   ` Adam Porter
2017-08-07 22:04     ` Kyle Meyer [this message]
2017-08-08 15:52       ` Adam Porter
2017-08-08 18:19         ` Kyle Meyer
2017-08-08 18:23           ` Kyle Meyer
2017-08-08 18:42           ` Adam Porter
2017-08-08 19:26             ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tivt4p1.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).