emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-table-separator-space breaks alignment of existing tables [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/il/.emacs.d/elpa/org-plus-contrib-20171225/)]
@ 2017-12-27 20:41 Ingo Lohmar
  2017-12-28 11:32 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Ingo Lohmar @ 2017-12-27 20:41 UTC (permalink / raw)
  To: emacs-orgmode


Here's a simple table example that breaks (info and columns lost etc) on
`org-table-align`.  I traced it down to org-table-separator-space ---
setting it to a plain " " (effectively the situation before the last
9.1.5 commit) works for me, but I do not understand why the change
breaks that.  Or is this "breakage" expected?

| No | Name            | cpr1 | drv1 | ?ch1 | fla1 | xt12 | enh       | pit1 | mtd1 | dly1 | xt11 | xt1 (2) | Amp [sd0 but def.3]  | Cab                          |           Rev | Comment                        |    | WIP/TODO                      |
|    |                 |      |      |      |      |      | rt/ph/trm |      |      |      |      |         |                      |                              |               |                                |    |                               |
|----+-----------------+------+------+------+------+------+-----------+------+------+------+------+---------+----------------------+------------------------------+---------------+--------------------------------+----+-------------------------------|
|  0 | JC 120          |    4 |      |    8 |    2 |      |           |      |    4 |    2 | DlyIn 30-100% |         | brt m10              | 94 2x12 slv alnico           |       sm room | 102bpm; orig ~CE-1 (more shimmer etc) |    |                               |

I have removed a few confidential settings, none of which I believe
could have anything to do with this issue.  I have a feeling it might
have something to do with org-indent-mode (would not be the first
time)...

Thanks for the ongoing work on org-mode!

Regards,
Ingo



Emacs  : GNU Emacs 27.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.24)
 of 2017-12-27
Package: Org mode version 9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/il/.emacs.d/elpa/org-plus-contrib-20171225/)

current state:
==============
(setq
 org-clock-persist-query-save t
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-scheduled-leaders '("++++" "%3d*")
 org-after-todo-state-change-hook '(my/org-prune-logbook-entries org-clock-out-if-current org-checklist)
 org-agenda-tags-column 78
 org-agenda-skip-scheduled-if-deadline-is-shown 'not-today
 org-blank-before-new-entry '((heading) (plain-list-item))
 org-babel-after-execute-hook '(my/org-babel-post-execute)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
 org-archive-save-context-info '(time olpath category itags ltags)
 org-src-tab-acts-natively t
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-special-ctrl-a/e t
 org-notmuch-open-function 'org-notmuch-follow-link
 org-agenda-files '("~/Documents/personal.org" "~/Documents/contacts.org" "~/Documents/collect.org")
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default
 org-tag-alist '(("computer" . 99) ("phone" . 112) ("read" . 114) (:startgroup) ("@context" . 64) (:grouptags) ("@home" . 104)
                 ("@work" . 119) ("@errand" . 101) (:endgroup))
 org-modules '(org-bibtex org-docview org-id org-info org-habit org-irc org-protocol org-indent org-checklist org-notmuch org-man
               org-contacts)
 org-startup-folded 'content
 org-cycle-include-plain-lists nil
 org-id-link-to-org-use-id 'use-existing
 org-mode-hook '(org-clock-load #[0 "\300\301!\207" [goto-address-mode -1] 2] #[0 "\301\211\207" [truncate-lines t] 2]
                 er/add-org-mode-expansions
                 #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-block-all append local] 5]
                 #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
                 org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load)
 org-clock-persist 'history
 org-odt-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-outline-path-complete-in-steps nil
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-startup-indented t
 org-startup-with-inline-images t
 org-tag-persistent-alist '(("REFILE" . 82))
 org-agenda-skip-timestamp-if-done t
 org-todo-repeat-to-state "NEXT"
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-latex-format-drawer-function #[514 "\207" [] 3 "\n\n(fn _ CONTENTS)"]
 org-contacts-matcher "Email<>\"\"|Birthday<>\"\"|Phone<>\"\"|Mobile<>\"\""
 org-agenda-deadline-faces '((1.0 . org-warning) (0.5 . org-upcoming-deadline) (0.0 . org-scheduled))
 org-contacts-files '("~/Documents/contacts.org")
 org-notmuch-search-open-function 'org-notmuch-search-follow-link
 org-babel-pre-tangle-hook '(save-buffer)
 org-file-apps '((directory lambda (file _link) (dired file)) ("\\.x?html\\'" lambda (file _link) (browse-url file))
                 ("\\.[eE]?[pP][sS]\\'" . default) ("\\.pdf\\'" . default) ("\\.rps\\'" . emacs) (auto-mode . emacs)
                 (t lambda (file _link) (my/dwim-open file)))
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-hide-leading-stars t
 org-babel-load-languages '((emacs-lisp . t) (shell . t) (python . t) (latex . t) (sql . t) (js . t) (dot . t) (scheme . t))
 org-agenda-time-grid '((daily require-timed remove-match) (800 1000 1200 1400 1600 1800 2000) " "
                        #(". . . . . . . . . . . . . . . . . . . . . . . . . . . " 0 54 (org-heading t)))
 org-log-done 'time
 org-agenda-skip-deadline-prewarning-if-scheduled t
 org-agenda-deadline-leaders '("XXXX" "%3d-" "X%3d")
 org-checklist-export-function 'org-export-as-ascii
 org-list-use-circular-motion t
 org-ascii-format-drawer-function #[771 "\207" [] 4 "\n\n(fn NAME CONTENTS WIDTH)"]
 org-ellipsis "⋯"
 org-habit-following-days 4
 org-agenda-bulk-mark-char "*"
 org-fast-tag-selection-single-key t
 org-src-lang-modes '(("sh" . sh) ("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa" . artist) ("asymptote" . asy)
                      ("dot" . fundamental) ("sqlite" . sql) ("calc" . fundamental) ("C" . c) ("cpp" . c++) ("C++" . c++)
                      ("screen" . shell-script) ("shell" . sh) ("bash" . sh))
 org-src-preserve-indentation t
 org-icalendar-include-todo t
 org-habit-today-glyph 124
 org-fontify-done-headline t
 org-agenda-timerange-leaders '("" "%d/%d:")
 org-catch-invisible-edits 'smart
 org-icalendar-date-time-format ";TZID=%Z:%Y%m%dT%H%M%S"
 org-agenda-prefix-format '((agenda . "  %-8 c%-12 t%5 s") (todo . "  %-8 c") (tags . "  %-8 c") (search . "  %-8 c"))
 org-occur-hook '(org-first-headline-recenter)
 org-agenda-mode-hook '(beginend-org-agenda-mode)
 org-cycle-separator-lines 0
 org-contacts-icon-use-gravatar nil
 org-agenda-window-setup 'current-window
 org-log-into-drawer t
 org-agenda-search-headline-for-time nil
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-todo-keywords '((sequence "TODO(t)" "NEXT(n)" "|" "DONE(d)") (type "WAIT(w)" "MAYBE(m)" "|" "CANCELED(c)"))
 org-support-shift-select t
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-tags-column 100
 org-habit-graph-column 60
 org-capture-mode-hook '((closure (t) nil (if (my/capture-frame-p) (progn (delete-other-windows))))
                         #[0 "\301\300!\210\302\211\207" [org-complete-tags-always-offer-all-agenda-tags make-local-variable t] 2]
                         )
 org-replace-disputed-keys t
 org-habit-show-done-always-green t
 org-M-RET-may-split-line '((headline . t) (default . t))
 org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
 org-babel-tangle-lang-exts '(("latex" . "tex") ("python" . "py") ("emacs-lisp" . "el") ("elisp" . "el"))
 org-icalendar-categories '(all-tags category)
 org-refile-use-outline-path 'file
 org-priority-faces '((65 :foreground "#d33682" :inherit (bold)) (66 :inherit default) (67 :inherit (my/org-dimmed default)))
 org-confirm-shell-link-function 'yes-or-no-p
 org-stuck-projects '("+LEVEL=2|project/!+TODO" ("NEXT") nil "")
 org-link-parameters '(("file+sys") ("file+emacs") ("lib" :follow my/org-bib-open :export nil) ("tel")
                       ("man" :follow org-man-open :export org-man-export :store org-man-store-link)
                       ("notmuch-search" :follow org-notmuch-search-open :store org-notmuch-search-store-link)
                       ("notmuch" :follow org-notmuch-open :store org-notmuch-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link)
                       ("info" :follow org-info-open :export org-info-export :store org-info-store-link) ("id" :follow org-id-open)
                       ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("doi" :follow org--open-doi-link)
                       ("elisp" :follow org--open-elisp-link) ("file" :complete org-file-complete-link)
                       ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path)))) ("help" :follow org--open-help-link)
                       ("http" :follow (lambda (path) (browse-url (concat "http:" path))))
                       ("https" :follow (lambda (path) (browse-url (concat "https:" path))))
                       ("mailto" :follow (lambda (path) (browse-url (concat "mailto:" path))))
                       ("news" :follow (lambda (path) (browse-url (concat "news:" path)))) ("shell" :follow org--open-shell-link))
 org-read-date-prefer-future 'time
 org-agenda-skip-scheduled-if-done t
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-agenda-block-separator ""
 org-treat-S-cursor-todo-selection-as-state-change nil
 org-habit-completed-glyph 120
 org-todo-keyword-faces '(("TODO" :foreground "#dc322f" :inherit (org-todo)) ("NEXT" :foreground "#d33682" :inherit org-todo)
                          ("DONE" . org-done) ("WAIT" :foreground "#b58900" :inherit (org-todo))
                          ("MAYBE" :inherit (org-todo my/org-dimmed)) ("CANCELED" :inherit (org-done strike-through)))
 org-clock-idle-time 10
 org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
 org-html-format-drawer-function #[514 "\207" [] 3 "\n\n(fn NAME CONTENTS)"]
 org-agenda-todo-ignore-with-date t
 org-agenda-entry-text-leaders "    | "
 org-habit-preceding-days 13
 org-archive-default-command 'org-archive-set-tag
 org-show-context-detail '((default . tree))
 org-disputed-keys '(([67108908] . [3 left]) ([67108903] . [3 right]))
 org-html-format-headline-function 'org-html-format-headline-default-function
 org-entities-user '(("geq" "\\geq" t "&ge;" ">=" ">=" "≧") ("leq" "\\leq" t "&le;" "<=" "<=" "≦")
                     ("eps" "\\eps" t "&epsilon;" "eps" "eps" "ε") ("del" "\\partial" t "&part;" "del" "del" "∂")
                     ("langle" "\\langle" t "&lang;" "<" "<" "⟨") ("rangle" "\\rangle" t "&rang;" ">" ">" "⟩")
                     ("ll" "\\ll" t "<<" "<<" "<<" "≪") ("gg" "\\gg" t ">>" ">>" ">>" "≫"))
 org-src-window-setup 'other-window
 org-confirm-babel-evaluate #[514 "\300\230?\207" ["dot"] 4 "\n\n(fn LANG BODY)"]
 org-agenda-todo-ignore-deadlines 'near
 org-directory "~/Documents"
 org-agenda-sorting-strategy '((agenda time-up habit-down deadline-up ts-up scheduled-up priority-down tag-up effort-down
                                category-keep)
                               (todo todo-state-down priority-down tag-up effort-down category-keep)
                               (tags priority-down category-keep) (search category-keep))
 org-clock-clocked-in-display 'both
 org-link-search-must-match-exact-headline nil
 org-use-speed-commands t
 org-tags-exclude-from-inheritance '("crypt")
 org-agenda-skip-deadline-if-done t
 org-agenda-todo-ignore-scheduled 'all
 org-default-notes-file "~/Documents/collect.org"
 org-agenda-current-time-string "now . . . . . . . . . . . . . . . . . . . . . . . . . "
 org-agenda-skip-unavailable-files t
 org-agenda-show-future-repeats 'next
 )

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug: org-table-separator-space breaks alignment of existing tables [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/il/.emacs.d/elpa/org-plus-contrib-20171225/)]
  2017-12-27 20:41 Bug: org-table-separator-space breaks alignment of existing tables [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/il/.emacs.d/elpa/org-plus-contrib-20171225/)] Ingo Lohmar
@ 2017-12-28 11:32 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-12-28 11:32 UTC (permalink / raw)
  To: Ingo Lohmar; +Cc: emacs-orgmode

Hello,

Ingo Lohmar <i.lohmar@gmail.com> writes:

> Here's a simple table example that breaks (info and columns lost etc) on
> `org-table-align`.  I traced it down to org-table-separator-space ---
> setting it to a plain " " (effectively the situation before the last
> 9.1.5 commit) works for me, but I do not understand why the change
> breaks that.  Or is this "breakage" expected?
>
> | No | Name            | cpr1 | drv1 | ?ch1 | fla1 | xt12 | enh       | pit1 | mtd1 | dly1 | xt11 | xt1 (2) | Amp [sd0 but def.3]  | Cab                          |           Rev | Comment                        |    | WIP/TODO                      |
> |    |                 |      |      |      |      |      | rt/ph/trm |      |      |      |      |         |                      |                              |               |                                |    |                               |
> |----+-----------------+------+------+------+------+------+-----------+------+------+------+------+---------+----------------------+------------------------------+---------------+--------------------------------+----+-------------------------------|
> |  0 | JC 120          |    4 |      |    8 |    2 |      |           |      |    4 |    2 | DlyIn 30-100% |         | brt m10              | 94 2x12 slv alnico           |       sm room | 102bpm; orig ~CE-1 (more shimmer etc) |    |                               |

Confirmed. There is an issue in maint, but not in master, as far as my
testing goes.

Since we are close to Emacs release, I'd rather postpone this change, so
I reverted it in maint branch while keeping it in master.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-28 11:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-27 20:41 Bug: org-table-separator-space breaks alignment of existing tables [9.1.5 (9.1.5-1-gb3ddb0-elpaplus @ /home/il/.emacs.d/elpa/org-plus-contrib-20171225/)] Ingo Lohmar
2017-12-28 11:32 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).