From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: bug#22776: interactive org-set-effort (C-c C-x e) and column view direct index selection do not handle Effort_ALL with more than 10 entries Date: Wed, 03 Jan 2018 09:39:40 +0100 Message-ID: <878tdf49pv.fsf@nicolasgoaziou.fr> References: <1513884685.1058242.1456181775684.JavaMail.yahoo.ref@mail.yahoo.com> <1513884685.1058242.1456181775684.JavaMail.yahoo@mail.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWeaj-0004hz-F3 for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 03:40:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWeag-0006we-DC for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 03:40:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:53356) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWeag-0006wT-9d for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 03:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eWeaf-0006GQ-Uk for emacs-orgmode@gnu.org; Wed, 03 Jan 2018 03:40:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <1513884685.1058242.1456181775684.JavaMail.yahoo@mail.yahoo.com> (David Caldwell's message of "Mon, 22 Feb 2016 22:56:15 +0000 (UTC)") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: David Caldwell Cc: 22776@debbugs.gnu.org Hello, David Caldwell writes: > This bug is a replacement of bug #22735(24.3; org-set-effort *without* > numeric prefix - still forces me to use nth allowed). =C2=A0After more > experimentation, I got a better understanding of the functionality and > now consider that bug 22735 to be invalid as written. =C2=A0I now think > it's a more fundamental issue of not handling an Effort_ALL with more > than 10 entries. =C2=A0The problems manifest in both interactive > org-set-effort and in column view when editing values via direct index > selection. > Problems:=C2=A0 1) interactive org-set-effort=C2=A0 =C2=A0 =C2=A01) can n= ot enter an index >> 10=C2=A0 =C2=A0 =C2=A02) method of entering a raw value is arcane and un= validated=C2=A0 > =C2=A0 =C2=A0 =C2=A0 - by prefixing the entered value by '-', you can ent= er one of > the Effort_ALL string directly=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - e.g. E= ffort_ALL 0 1h 2h 4h > 1d 2d 3d 4d 1w 2w 3w 4w=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - 'C-c C-x e -4= w RET' sets Effort to > '4w'=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - however, a value of '-foobar' se= ts Effort to 'foobar'=C2=A0 > =C2=A0 =C2=A03) Note: org-set-effort with numerical prefix works properly= for > indices > 10=C2=A0 2) column view - editing values=C2=A0 =C2=A0 =C2=A01) = 1-9,0 - can not > enter an index > 10=C2=A0 =C2=A0 =C2=A0 =C2=A0 - lower priority than 1.1 = above since > column view edit 'e' allows direct entry of Effort_ALL strings (with > validation)=C2=A0 =C2=A0 =C2=A02) Note: S-left/right, n, p work properly = for indices >> 10Proposed solution:=C2=A0 - interactive org-set-effort and column view > direct index selection=C2=A0 =C2=A0 - input multiple characters followed = by RET=C2=A0 > =C2=A0 - if input is a valid index, use the corresponding value from > Effort_ALL=C2=A0 =C2=A0 - else if input is a valid Effort_ALL value, use = it=C2=A0 =C2=A0 - > else beep and display [No Match] (like column view edit when an > invalid value is entered) I've changed `org-set-effort' to use `completing-read' for allowed values instead of relying on position in list. The prefix argument now means "increment".=20 This is simpler and less exotic. WDYT? Regards, --=20 Nicolas Goaziou 0x80A93738