From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Bug or not a bug? dot expansion in ob-shell Date: Fri, 21 Feb 2020 09:04:19 +0100 Message-ID: <878skwbc3g.fsf@bzg.fr> References: <87eeur3p1p.fsf@ucl.ac.uk> <87a75eap8k.fsf@gnu.org> <87y2sy3kkl.fsf@ucl.ac.uk> <87r1yq4xiz.fsf@gnu.org> <875zg2kcy0.fsf@ucl.ac.uk> <87h7zmiw0v.fsf@gmail.com> <871rqqag19.fsf@bzg.fr> <87wo8iitzz.fsf@ucl.ac.uk> <87ftf63d79.fsf@gnu.org> <87pnear7tl.fsf@ucl.ac.uk> <87v9o236v1.fsf@gnu.org> <8736b66z6t.fsf@gnu.org> <877e0h571l.fsf@alphaville.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:37996) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j53IM-00081S-Oi for emacs-orgmode@gnu.org; Fri, 21 Feb 2020 03:04:23 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Nick Dokos Cc: emacs-orgmode@gnu.org Hi Nick, I didn't conduct the survey in 2013, you can find the results here: https://orgmode.org/worg/org-configs/org-customization-survey.html I understand why you (and Tim and Derek) think an option is too much. But let's separate two problems: one is that Org have many options, some perhaps unneeded (or only here because of bad design decisions we made in the past), causing a technical debt, another one being "How to handle shell's notion of "return value" in ob-shell.el? The first problem is real: patches are always welcome in this area but this is the kind of problem that requires a big picture and a strong push, incremental fixes are difficult here. The second problem is real too, and while being cautious about not making the first problem worse, the solution should be independant. That said, we have three solutions: 1. Stick to a strict reading of Org and bash manuals: the absence of a :results header means "return the value, i.e. the exit status". 2. Deviate from this strict reading, introduce an exception for *all* shell blocks: no :results header means "return output" and you need to use :results value to get the exit status (your proposal). 3. Deviate from this strict reading and introduce an option that says: "Don't deviate from the Org's and bash manuals for all src blocks". Obviously, nobody wants the first solution. Part of me agrees with your second solution: after all, we had to wait until Vladimir's "echo ." trick to find out there was a problem. Part of me think that (1) deviation from the normal behavior should be carefully advertized and (2) by design, the normal behavior should not require tweaking options manually for each block. An option fulfills both these needs: allowing to get the normal behavior by default and advertizing the "deviation". Right now I'm not convinced we should get rid of this option. But I'm convinced we should take the decision we no consideration of the first (biggest) problem of Org having *perhaps* too many options. Case still open. -- Bastien