emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: juanjose.garcia.ripoll@csic.es (Juan José García Ripoll)
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-publish-sitemap messes absolute sitemap paths [9.3.6 (9.3.6-25-g685b2c-elpa @ c:/Users/juanj/OneDrive/Library/Emacs/elpa-26/org-20200316/)]
Date: Sat, 18 Apr 2020 18:23:36 +0200	[thread overview]
Message-ID: <878sisyd87.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <86r1wmum3p.fsf@csic.es> ("Juan =?utf-8?B?Sm9zw6kgR2FyY8Ot?= =?utf-8?B?YQ==?= Ripoll"'s message of "Fri, 17 Apr 2020 18:13:14 +0200")

Hello,

> The line
>
>   (sitemap-filename (concat root (or sitemap-filename "sitemap.org")))
>
> in ox-publish.el prevents the user from using an absolute path for the
> location of the sitemap. This is also not very good practice, because
> concatenation does not guarantee good pathnames. Instead it should read
>
>   (sitemap-filename (expand-file-name (or sitemap-filename
>                                                                                  "sitemap.org")
>                                                                           root))

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou


      reply	other threads:[~2020-04-18 16:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 16:13 Juan José García Ripoll
2020-04-18 16:23 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sisyd87.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=juanjose.garcia.ripoll@csic.es \
    --subject='Re: Bug: org-publish-sitemap messes absolute sitemap paths [9.3.6 (9.3.6-25-g685b2c-elpa @ c:/Users/juanj/OneDrive/Library/Emacs/elpa-26/org-20200316/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).