emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Mario Frasca <mario@anche.no>
Cc: emacs-orgmode@gnu.org
Subject: Re: [bug] select TODO items and unexpected behaviour
Date: Sun, 28 Jun 2020 16:06:20 -0400	[thread overview]
Message-ID: <878sg7arb7.fsf@kyleam.com> (raw)
In-Reply-To: <10f954f3-0f17-ff93-cb49-bfb256a5e664@anche.no>

Mario Frasca writes:

> On 28/06/2020 01:32, Kyle Meyer wrote:
>> Thanks for reporting. Looks like org-todo's call to org-map-entries has
>> been broken since its introduction in 7.8.05.  Should be fixed with
>> 8a2eb7d1b.
>
> 3ed035ce3
>
> with this patch, you don't need to locally redefine the 
> org-loop-over-headlines-in-active-region variable, do you?

What have you tried on your end to answer that?  Here are some
approaches:

  * Read the commit message in 3ed035ce3 (org.el: Clarify argument in
    org-todo's call to org-map-entries).  Does its explanation fit with
    your understanding?  Perhaps it's wrong or not written clearly, but
    it seems like a good starting point.

  * Drop the let-binding of org-loop-over-headlines-in-active-region in
    org-todo, and try it out.  Does it work as before?  Better yet, step
    through the call of the function, comparing the behavior before and
    after.

  * Drop the let-binding and run the test I added in 8a2eb7d1b (org.el:
    Fix org-todo argument handling when looping over region).


  reply	other threads:[~2020-06-28 20:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 21:16 Mario Frasca
2020-06-27 21:43 ` Mario Frasca
2020-06-27 21:54   ` Mario Frasca
2020-06-28  6:32   ` Kyle Meyer
2020-06-28 14:53     ` Mario Frasca
2020-06-28 18:50     ` Mario Frasca
2020-06-28 20:06       ` Kyle Meyer [this message]
     [not found]     ` <32b85f8a-3f26-15d8-8d93-cbdd222ab3db@anche.no>
2020-06-28 20:04       ` Kyle Meyer
2020-06-27 22:46 ` Russell Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sg7arb7.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mario@anche.no \
    --subject='Re: [bug] select TODO items and unexpected behaviour' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).