From: Nick Dokos <firstname.lastname@example.org> To: email@example.com Subject: Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list Date: Tue, 07 Jul 2020 09:38:25 -0400 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Kyle Meyer <firstname.lastname@example.org> writes: > ,,, > I think this patch is a clear improvement as is, but in the context of > completion (and the stack exchange post you link to), isn't the handling > around *_ALL keywords still a bit off? It seems a caller would want to > complete without the _ALL; to use the example from that post, with > "#+PROPERTY: GENRE_ALL ...", the caller would want to complete "GENRE". > Is it worth providing special handling here? > With a bit of caffeine in my system, I now see what you wrote and I think you are right: if the _ALL property is present, then the bare property should be added to the completion list if not already there. -- Nick "There are only two hard problems in computer science: cache invalidation, naming things, and off-by-one errors." -Martin Fowler
next prev parent reply other threads:[~2020-07-07 13:38 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-07 2:01 Nick Dokos 2020-07-07 2:40 ` Nick Dokos 2020-07-07 4:23 ` Kyle Meyer 2020-07-07 12:44 ` Nick Dokos 2020-07-07 13:38 ` Nick Dokos [this message] 2020-07-07 16:48 ` Nick Dokos 2020-07-08 3:52 ` Kyle Meyer 2020-07-08 15:47 ` Nick Dokos 2020-07-08 16:07 ` Nick Dokos 2020-07-09 4:36 ` [PATCH] agenda: Fold case when retrieving user-configured effort values Kyle Meyer 2020-07-09 7:50 ` Nick Dokos
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).