From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SPvEGg+uFmAuZgAA0tVLHw (envelope-from ) for ; Sun, 31 Jan 2021 13:18:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6M5pFg+uFmCfXAAAbx9fmQ (envelope-from ) for ; Sun, 31 Jan 2021 13:18:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B73489404DF for ; Sun, 31 Jan 2021 13:18:06 +0000 (UTC) Received: from localhost ([::1]:36252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6Cc9-00016O-Mz for larch@yhetil.org; Sun, 31 Jan 2021 08:18:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Cax-00016G-2R for emacs-orgmode@gnu.org; Sun, 31 Jan 2021 08:16:51 -0500 Received: from mout02.posteo.de ([185.67.36.66]:38351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Cau-0006xK-Bn for emacs-orgmode@gnu.org; Sun, 31 Jan 2021 08:16:50 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 68A632400FC for ; Sun, 31 Jan 2021 14:16:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1612099005; bh=zRT52FI1Qe/qQJah+R2f04jU/VWuyi+4cpuRoY6gAAw=; h=From:To:Cc:Subject:Date:From; b=jhblW89dle710+/UeUV9ssdHiqplwNmKfqZ1U0L6/TaR48feSPKdhX81f6KjQBWf+ zbsPIzh1gb41e5mvw7ecBHhXrw2UctXDjWH2u1vtwbMj2mdmo9FsoVl6SmmduyOlD0 XP/RGJeE22JiwI4lomQrTO2G8P8xUHFuB5Qahp1gQklfBdxrpaskmPK9swJdfFw4Bg Y+e1IE6wL3JSDbjvgWa32EkNwot7wZdZUcJDqDkqgnYbLtCxb4Y62UImocl3sBPIxc gZvbA8Uf52gHeumkubVQyAhJKo5xBYoLl9ZSEozBPCWGjkDj/+Sc/hsU/baT70CRDH pINkZ37g7S5AA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DTBRw69lcz9rxQ; Sun, 31 Jan 2021 14:16:44 +0100 (CET) From: =?utf-8?Q?Juan_Manuel_Mac=C3=ADas?= To: Ihor Radchenko Subject: Re: org-attach-git don't automatically commit changes References: <87czxn91dj.fsf@posteo.net> <87a6sr6mcq.fsf@localhost> <8735yiv926.fsf@posteo.net> <87wnvt4w62.fsf@localhost> <87r1m1o0vz.fsf@posteo.net> <87k0rt4bvc.fsf@localhost> Date: Sun, 31 Jan 2021 14:16:44 +0100 In-Reply-To: <87k0rt4bvc.fsf@localhost> (Ihor Radchenko's message of "Sun, 31 Jan 2021 18:52:23 +0800") Message-ID: <878s89nt4z.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=maciaschain@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=jhblW89d; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: B73489404DF X-Spam-Score: -3.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: clmNcrEwXqlj Ihor Radchenko writes: > The other thing is that `org-attach-id-dir' makes much less sense from > the time :DIR: property was introduced. So, I believe that > org-attach-git should be updated. Probably, handling attachment dirs as > individual git repos can be one of the ways to upgrade the current > version. I guess, patches welcome. Do you think a possible patch could simply consist of replacing (as I have done) `(expand-file-name org-attach-id-dir)' by `(org-attach-dir)' in `org-attach-git-commit'? This would allow you to handle attachment dirs as individual git repos, regardless of :ID: or :DIR: properties, since "[(org-attach-dir)] Return the directory associated with the current outline node. First check for DIR property, then ID property [...]". Best regards, Juan Manuel