From: Nicolas Goaziou <email@example.com> To: Tom Gillespie <firstname.lastname@example.org> Cc: emacs-orgmode <email@example.com> Subject: Re: Bug: inconsistent escaping of coderef regexp Date: Sat, 10 Apr 2021 00:19:40 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CA+G3_PONzfmfB-UpUcE3jzPw5fVsbjzTeCCO4UkToa9NeUUUemail@example.com> (Tom Gillespie's message of "Wed, 7 Apr 2021 12:44:28 -0700") Hello, Tom Gillespie <firstname.lastname@example.org> writes: > I've included the simplest patch I could come up with for the > divergence in behavior between org-babel-tangle-single-file and > org-link-search. Thank you. I applied it. > https://code.orgmode.org/bzg/org-mode/src/2d78ea57cfad1ddc3e993c949daf117b76315170/lisp/org-src.el#L882 > > That line defines a hardcoded regular expression for matching > coderefs. It is a reasonable one, however, since it just means "the coderef is the last thing on the line". > The codref prefix is the first =[ \t]*= and the coderef > regexp is the equivalent to the fully formatted version of that format > string. Neither of those can currently be specified by the user. [...] > The coderef prefix is something that should probably be configurable > by the user so that empty comments are not left in the file. I'm not convinced this should be configurable, as I fail to see a use-case for such a customization. Note that in the case you mention, comment syntax should probably be part of the coderef label itself. Regards, -- Nicolas Goaziou
prev parent reply other threads:[~2021-04-09 22:20 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-04 20:33 Tom Gillespie 2021-04-01 15:45 ` Nicolas Goaziou 2021-04-01 16:09 ` Timothy 2021-04-04 22:01 ` Tom Gillespie 2021-04-04 23:12 ` Nicolas Goaziou 2021-04-05 5:22 ` Tom Gillespie 2021-04-05 7:42 ` Tom Gillespie 2021-04-07 17:58 ` Nicolas Goaziou 2021-04-07 19:44 ` Tom Gillespie 2021-04-09 22:19 ` Nicolas Goaziou [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Bug: inconsistent escaping of coderef regexp' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).