emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Make org-load-hook obsolete
@ 2021-05-07 12:57 Stefan Kangas
  2021-05-08  7:34 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Kangas @ 2021-05-07 12:57 UTC (permalink / raw)
  To: Org-mode

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

In Emacs, we have made all the `foo-load-hook' variables obsolete in
favor of `with-eval-after-load'.  The attached patch does the same for
org-mode.

[-- Attachment #2: 0001-Make-org-load-hook-obsolete.patch --]
[-- Type: text/x-diff, Size: 801 bytes --]

From dcf7bfa11a2d27ca9fd44d8fd11440e033b2c567 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Fri, 7 May 2021 14:50:48 +0200
Subject: [PATCH] Make org-load-hook obsolete

* lisp/org.el (org-load-hook): Make obsolete in favor of
with-eval-after-load.
---
 lisp/org.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org.el b/lisp/org.el
index 675a614e2..39a44016e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -653,6 +653,8 @@ defined in org-duration.el.")
   "Hook that is run after org.el has been loaded."
   :group 'org
   :type 'hook)
+(make-obsolete-variable 'org-load-hook
+                        "use `with-eval-after-load' instead." "Org 9.5")
 
 (defcustom org-log-buffer-setup-hook nil
   "Hook that is run after an Org log buffer is created."
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Make org-load-hook obsolete
  2021-05-07 12:57 [PATCH] Make org-load-hook obsolete Stefan Kangas
@ 2021-05-08  7:34 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2021-05-08  7:34 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Org-mode

Hi Stefan,

Stefan Kangas <stefan@marxist.se> writes:

> In Emacs, we have made all the `foo-load-hook' variables obsolete in
> favor of `with-eval-after-load'.  The attached patch does the same for
> org-mode.

Applied in master, thank you.

-- 
 Bastien


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-08  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 12:57 [PATCH] Make org-load-hook obsolete Stefan Kangas
2021-05-08  7:34 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).