From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GOYeM9F8T2GBOQAAgWs5BA (envelope-from ) for ; Sat, 25 Sep 2021 21:47:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gBiTLtF8T2FsbwAAbx9fmQ (envelope-from ) for ; Sat, 25 Sep 2021 19:47:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FE8B28151 for ; Sat, 25 Sep 2021 21:47:29 +0200 (CEST) Received: from localhost ([::1]:46866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUDdw-0001so-IJ for larch@yhetil.org; Sat, 25 Sep 2021 15:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUDdC-0001qc-NZ for emacs-orgmode@gnu.org; Sat, 25 Sep 2021 15:46:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54140) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUDdC-0003Ma-8p; Sat, 25 Sep 2021 15:46:42 -0400 Received: from [2a01:e34:ec2b:7150:15f9:5c70:2a21:7821] (port=45314 helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUDdB-0006S3-To; Sat, 25 Sep 2021 15:46:42 -0400 Received: by hal (Postfix, from userid 1000) id 318391E041B; Sat, 25 Sep 2021 21:46:39 +0200 (CEST) From: Bastien To: Adam Porter Subject: Re: [BUG] 81c7a2dee8 misaligns time lines in agenda In-Reply-To: <87czr6uhhk.fsf@alphapapa.net> (Adam Porter's message of "Sun, 25 Jul 2021 18:00:07 -0500") Organization: GNU References: <87czr6uhhk.fsf@alphapapa.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 25 Sep 2021 21:46:39 +0200 Message-ID: <878rzkcuao.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632599249; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=AdnxHC3wp1EC9VQXf/QxtMYgwh+d6YXyEIHnbOGYDlg=; b=qbnAiRAAZDvTIg9XKt7qNJxwYbjO9TBPo0FYX7HUKuZ81nZusH6U+Qns1wtAsu5ImPqajY +4+qeDgQHUPCRnIGaO8DklDtj4RVwp346PgoNL2KgjyIpNi9LIhprACZevG2kwEQ/r8omp 1Upv3K2tuBAtV2HOIk2icDfq6d51a+PiGMaFVmt2WeAPnY8uI5kTJox+enTvxKwrZO329p jB9Prub6zkyCcP0rGssC6XhOOZ/tfIEDfzln0p+gauH3km6CgcPSvsELDkTW402NUVvomz AjT0ormUPS5SZDm+ri/OT+rgbTOL33wjOT5xSBMBOEncBOPH7y68h2oExrZ9Xg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632599249; a=rsa-sha256; cv=none; b=uCHfGXNNbTBWd4jRgILTQrodyXpV7JiMOLqu1s/XukDSsogb4jXCj9tC+Pt6QkpaYlt/nX xrObGiVaUitUszMG4NrHNELIL/BP7+PYHwDUQWoBk162WgfjI0Zsm6a1t5LuwyoFPUX/MM FqvuFIWibCKpfnqKAx8zfArN3Jns6w7NYN1lERZRGwyqLKrmr1SV9yuWKMES7fVJNUz2uo 4KIRyv38Wo6vEr3IBt3FJPbjFxL+wcQnzZD1CiiPWnCiKIIkKlBuCi6q/nmaukK1QercIb mlTZ7xhF3vZpMoZBNx7YvruWRZQPpro9agG81h+5UuAob5Gx9Vdcs74oBrYwSg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.49 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 6FE8B28151 X-Spam-Score: -3.49 X-Migadu-Scanner: scn1.migadu.com X-TUID: w/CkJIKJ/Q+r Hi Adam, Adam Porter writes: > In the course of working on a PR for org-super-agenda [0], we found that > a recent change to Org, commit 81c7a2dee8 [1], causes a misalignment in > the way time lines in the agenda are displayed. The org-super-agenda > test suite shows this change when results from Org 9.4 and 9.4.6 are > compared. For example, in this diff of an agenda buffer: > > #+BEGIN_EXAMPLE diff > @@ -2,8 +2,8 @@ > Wednesday 5 July 2017 > > Today > - test: 7:02...... Sunrise (12:04 of daylight) > - 8:00...... ---------------- > + test: 7:02...... Sunrise (12:04 of daylight) > + 8:00...... ---------------- > 10:00...... ---------------- > 12:00...... now - - - - - - - - - - - - - - - - - - - - - - - - - > 12:00...... ---------------- > #+END_EXAMPLE > > The old lines, with single-digit hours, were properly aligned with the > lines with multi-digit hours, but the new lines are one character too > far to the left. > > Since Bastien made this change, and it's very simple, I'm guessing he'll > know what the proper fix is. :) The change I made was superceded by Nicolas series of patches: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/log/?qt=grep&q=fix+org-duration-to-minutes+error I agree the new alignment looks wrong: the starting time should bit right-aligned with other time above/below, and the separating dash should not spaces for "HH:MM" time strings on the right, but only for " H:MM". Would you have time to prepare a patch for this?