From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ioxAGOgcYGFO7QAAgWs5BA (envelope-from ) for ; Fri, 08 Oct 2021 12:26:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iG9PE+gcYGFPPQAAB5/wlQ (envelope-from ) for ; Fri, 08 Oct 2021 10:26:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D4567F800 for ; Fri, 8 Oct 2021 12:26:47 +0200 (CEST) Received: from localhost ([::1]:43990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYn5S-0002lk-K9 for larch@yhetil.org; Fri, 08 Oct 2021 06:26:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYn1S-0007hi-P2 for emacs-orgmode@gnu.org; Fri, 08 Oct 2021 06:22:38 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:41583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYn1M-0004Yo-F0 for emacs-orgmode@gnu.org; Fri, 08 Oct 2021 06:22:38 -0400 Received: by mail-wr1-x42f.google.com with SMTP id t2so28208263wrb.8 for ; Fri, 08 Oct 2021 03:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BKzcxkhBMVfcGSGIV1fVFSDxP5DY0FEOJ+eN7EVXzDc=; b=XXTR2NWajahM9f7qo/Tuet0NF/ZENLU4ehnPaMKnd1Kq829i3TnMsyRgxG7PFX8rqj KZQS+8enifETiudv2tP7fYdRQNSFnsNu4UbqsELpYO4UUm/bYh38jJE+WnwjUXE5l9ES vTGqrSWm9a0f+grBIXhjA9dh1kdqM51SOcjMO7uDe8BA8gMxtROeXbANjUE+jWvZ7zbw WPiZLNUftm2kmu5iWdb6zJP9spmvVi2Z4L8jdHEmRgZxm55peb3gE6u/LaGi0oQhrQaL sbSEJjlTkDS2FfekM/xdnyvE6dHDfDv2XVammQs3DrmvBBk1mu4DwIPKU8t5oIHWr7Zi pnIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BKzcxkhBMVfcGSGIV1fVFSDxP5DY0FEOJ+eN7EVXzDc=; b=TTUZ1wYCEdsSfVOYDr7xBvjVLSFGsid3w6oNjfX3b6VfrpRwethfq/Bk5c3sj6tuIE mPtgE8tIK5rxv17oR2CDiNQSmoDNN2YRDWH7g9DeI4LAVOfQ8GRrt93Wzup0wQZaQcd3 LrW8zPh1j0qUSrG9qV+NQI3yPEK32DEzDUw3oM+owCfACixgxrBE7ITwOgQ7ZH3WRYSg 5ezT1W+FBxzxQCkq5C1iEJpGZ3zmZjicbegIaiVmBwxw6Y6kiEVFAy1XMV6mT2FsNvZG 8mIGcV/ICo0XvHAKgB066mwU66Vd3d0Xdas6X/BGuq8IFHuaJuarHECkG2BtIJhZAb9N +/EQ== X-Gm-Message-State: AOAM533/sc2TRrYkbEe7k790vM+PduXd0/Xb0V1oREUv9ZW253WKccHy uOmPFmBj22R2JNJr3fat5YHRbUKZILE= X-Google-Smtp-Source: ABdhPJzWVyd4u7CJHVy0xyxLjui5+8LUEMtZIm4MmCexppuo17bF+go5HL8oe+4YYJbuV2/YdQFM9w== X-Received: by 2002:a05:600c:4e86:: with SMTP id f6mr2507754wmq.166.1633688549603; Fri, 08 Oct 2021 03:22:29 -0700 (PDT) Received: from aspire-5942 (p200300d86744350051ca2b0e59096abb.dip0.t-ipconnect.de. [2003:d8:6744:3500:51ca:2b0e:5909:6abb]) by smtp.gmail.com with ESMTPSA id m15sm859267wmq.0.2021.10.08.03.22.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Oct 2021 03:22:28 -0700 (PDT) From: Marco Wahl To: Max Nikulin , Ihor Radchenko , Adam Porter Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> Date: Fri, 08 Oct 2021 12:22:18 +0200 In-Reply-To: (Max Nikulin's message of "Thu, 7 Oct 2021 23:14:45 +0700") Message-ID: <878rz3ddet.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=marcowahlsoft@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633688807; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BKzcxkhBMVfcGSGIV1fVFSDxP5DY0FEOJ+eN7EVXzDc=; b=eRUXnFVaVYiuNrYyC7sPXF9OjNatIXPJbX377sedBfPiG4mo5rEQMTHfVvV8AMY1mw0OEI BlktzNdTjQ5qHmDTwb4MP5mPXYYbk+CJ8c9wSwzBgqOs4Yka2NlWKp5rh6U9ZOv2wawJ5t QhuF6geghC1YuYmFoIeAba+pyRpF+XfMtubzM/p305V9xvQsfcMX7i6/eXfdC4402UaS9V aRPxrh+XsPIdKVrXeBLQeu/O/vtrOYBhaDWl7vaMlpKMEigZZpGAysCMG3nJ7g0970fjut WX2FeQ/Ufm6VSWXIR24zuqsNSHgoQJWXw7WtGANHP35/Z2QNvkk7DvsAYyKDyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633688807; a=rsa-sha256; cv=none; b=ep0SXBcSBbr4q8Vk5NsJb39U1qdSAZuGxz5HiNPffYl814ooVzFlEFs0Vw4Sh85rdu9eZF 5KcLMu+mCvhvUMbcB1j/SuWXXitzHRju+nb5OaFWzXL6tzLdsI1tNI9UZZzQ2rVxYj8LG1 1Do2sj9wMPV6zhWSGKBy/a4yiMjVWEGEUTaC/xwosdn9n3PC8y0mmDwu1NaxcxrcQOmti2 GNV3zVn9QPgRHRnGlv6/mw6WwCBKgl/ov9BdqMoYo18E+tFK3l1NYrvjtY1kTAlW19SS9V N08dqR7lRSyQtts8QI53Mef47k37YRpTVOdiRmeaTkYtuLQWEyctqjUlNySv6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XXTR2NWa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XXTR2NWa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D4567F800 X-Spam-Score: -1.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: ns0qWtcGMAb6 Max Nikulin writes: > On 05/10/2021 23:32, Ihor Radchenko wrote: >> Max Nikulin writes: >> I tried come up with the reason why org-no-popup was used in the >> initial >> implementation. I think, the reason is avoiding situation like what you >> may see after running >> (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) >> So, removing the macro completely is not a good idea. >> I have updated the patch that should work without dropping the >> macro. >> See the attached. > > Thank you, Ihor. > > Your updated patch works in default configuration (-Q). I am not > familiar with knobs of `display-buffer' function so I have no idea if > someone may complain that such variant overrides his setup or works > incorrectly with his preferences. Please note the documentation of variable `pop-up-windows'. This variable is provided mainly for backward compatibility and should not be used in new code. The same holds for `pop-up-frames'. The drop of the macro looks like a good idea to me. Can someone please describe the price for dropping macro `org-no-popups'? @Ihor I do not understand what "situation" you mean.