From: Jan Seeger via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
To: emacs-orgmode@gnu.org
Subject: Bug: org-no-popups disregards display-buffer-fallback-action [9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)]
Date: Wed, 10 Nov 2021 08:50:49 +0100 [thread overview]
Message-ID: <878rxw5u06.fsf@thenybble.de> (raw)
Hello!
I'm trying to make multi-frame emacsing nicer, and I encountered what I
consider a bug with the `org-no-popups` macro in `org-macs.el`.
`org-no-popups` tries to surpress the creation of new frames via setting
`pop-up-frames` and `display-buffer-alist` to nil temporarily. This does
not take `display-buffer-fallback-action` into account, which is the
preferred way of making Emacs pop up new frames (or not, as the case may
be). When the fallback variable is set, code run inside `org-no-popups`
still creates new popups, which causes functions such as
`org-insert-link` to fail, or at least act *very* confusingly.
The preferred way of overriding the behavior of `display-buffer` for
localized Emacs code seems to be the variable
`display-buffer-overriding-action`.
Changing the definition of `org-no-popups` to
```
(defmacro org-no-popups (&rest body)
"Suppress popup windows and evaluate BODY."
`(let ((display-buffer-overriding-action '(display-buffer-pop-up-window)))
,@body))
```
correctly makes org pop up windows instead of frames.
Please contact me if you have any questions!
Best regards,
Jan Seeger
---
Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0)
Package: Org mode version 9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)
next reply other threads:[~2021-11-10 8:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 7:50 Jan Seeger via General discussions about Org-mode. [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-10 7:50 Bug: org-no-popups disregards display-buffer-fallback-action [9.4.6 (9.4.6-13-g4be129-elpaplus @ /home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)] Jan Seeger via General discussions about Org-mode.
2021-11-10 10:20 ` Ihor Radchenko
2021-11-13 17:34 ` dal-blazej
2021-11-14 6:08 ` Ihor Radchenko
2021-11-14 12:13 ` Eric S Fraga
2021-11-14 12:40 ` Ihor Radchenko
2021-11-14 19:37 ` Eric S Fraga
2021-11-14 23:03 ` dal-blazej
2021-11-15 9:57 ` Eric S Fraga
2021-11-15 19:40 ` Daniel Kraus
2024-04-12 17:59 ` Ihor Radchenko
2024-01-24 14:01 ` Ihor Radchenko
2024-01-25 3:10 ` Christopher M. Miles
2021-11-15 7:41 ` Jan Seeger via General discussions about Org-mode.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rxw5u06.fsf@thenybble.de \
--to=emacs-orgmode@gnu.org \
--cc=jan.seeger@thenybble.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).