From: Ihor Radchenko <firstname.lastname@example.org> To: Kaushal Modi <email@example.com> Cc: emacs-org list <firstname.lastname@example.org>, John Mathena <email@example.com> Subject: Re: [BUG] org-element--cache gives "Unregistered buffer modifications" warning [9.5 (9.5-g859984 @ /home/john/.emacs.d/straight/build/org/)] Date: Sat, 18 Dec 2021 12:35:51 +0800 [thread overview] Message-ID: <878rwiil7c.fsf@localhost> (raw) In-Reply-To: <CAFyQvY3Qv5xn-ET83L6Rzg-V1zOVu4y1gt+-_CpfaWNAdt87xA@mail.gmail.com> Kaushal Modi <firstname.lastname@example.org> writes: > I actually run a wrapper script to update Org and that has all that: > ... > I verified that at least the git hash was latest as of then: > release_9.5-364-g*de022e* Odd. Though the commit number is indeed correct. > There's a setup included in there; I forgot about that. If you don't mind > trying it again, this would download everything needed: Thanks! I was able to follow your steps this time. > Sorry, but I am getting similar backtrace in another function now: Sigh... Should be fixed now. I did not expect that arguments to cache functions could ever be markers. After the fix, I was able to see the warning you were talking about in the earlier email. Your test case revealed an important omission in the cache logic when a huge number of edits are stacked together into asynchronous cache queue. Thanks you for providing the excellent reproducer! On latest main, your example file is exported without any warnings. Also, I noticed that the large number of edits makes the cache use a lot of memory adding load onto the Emacs garbage collector. May I know what exactly ox-hugo does that triggers that many edits? Exporting your example files took approximately 30sec on my system (both with and without cache). I believe that the speed can be improved if cache is used more optimally. > *Another observation: * > > I see this warning when building from the latest main: > > In org-element--cache-sync: > org-element.el:5935:19: Warning: assignment to free variable > ‘org-element--cache-change-warning’ Thanks! Fixed. Best, Ihor
next prev parent reply other threads:[~2021-12-18 4:35 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-07 20:22 John Mathena 2021-11-08 5:59 ` Ihor Radchenko 2021-12-16 2:29 ` Kaushal Modi 2021-12-16 2:34 ` Kaushal Modi 2021-12-16 4:20 ` Ihor Radchenko 2021-12-16 14:33 ` Kaushal Modi 2021-12-16 15:18 ` Ihor Radchenko 2021-12-16 16:16 ` Kaushal Modi 2021-12-18 4:35 ` Ihor Radchenko [this message] 2021-12-18 17:43 ` Kaushal Modi 2021-12-19 9:47 ` Ihor Radchenko 2022-04-24 3:37 ` Difference seen in org-version strings when built from git Kaushal Modi 2022-04-24 3:59 ` Ihor Radchenko 2022-01-06 11:17 ` [BUG] org-element--cache gives "Unregistered buffer modifications" warning [9.5 (9.5-g859984 @ /home/john/.emacs.d/straight/build/org/)] Karl Voit 2022-01-06 12:25 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=878rwiil7c.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [BUG] org-element--cache gives "Unregistered buffer modifications" warning [9.5 (9.5-g859984 @ /home/john/.emacs.d/straight/build/org/)]' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).