From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0AQNMlSWWmKCPwAAgWs5BA (envelope-from ) for ; Sat, 16 Apr 2022 12:11:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oDWwLlSWWmJJEAEAauVa8A (envelope-from ) for ; Sat, 16 Apr 2022 12:11:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A9B72D753 for ; Sat, 16 Apr 2022 12:11:32 +0200 (CEST) Received: from localhost ([::1]:34628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nffOt-0006rP-0M for larch@yhetil.org; Sat, 16 Apr 2022 06:11:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nffNk-0006px-Ji for emacs-orgmode@gnu.org; Sat, 16 Apr 2022 06:10:20 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:44767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nffNi-0003iM-K9 for emacs-orgmode@gnu.org; Sat, 16 Apr 2022 06:10:20 -0400 Received: by mail-pl1-x62d.google.com with SMTP id j8so8819180pll.11 for ; Sat, 16 Apr 2022 03:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=/FF1R7iqXavNOY/ntMplStRcZqxDjKqbnWMuQ3bEXyI=; b=aZysvKE0u9BwQwB4MmVnhbvC47vyjiwrKkg7QRt3tr6zXfQE5+gCZP+dUzGbKf8ckK vZ3ThICL6jXkAw2EZs2wwRKHhjPh2YbZfPO4/xqhgOuKcpyeLN0nDwiwzJE7okouPRah 5TzZKUbOYEw3QGyAgDpkM936FrQVZAwMHb6Z8irqU9m4gKxt9b+SyNaVBHjLalrWp12a stJRurYj90cqPDXLrMoMZrcn+Ue5oAyQqRQtZl5b0GW34NoylQ/Hs3BqQ+I3PyTeKrA3 qCIk3qyDCZ6vQDhBPJjIOYK2/aBaAs/z9H5VG3FIufrOyTehfYOkNs2o/6c7Iz93FRL5 cLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=/FF1R7iqXavNOY/ntMplStRcZqxDjKqbnWMuQ3bEXyI=; b=kT6KMoAwdLmL91iecoBfv8nfqYIrh3lSgVpt+OFfSctPJXS63ZeSTNxwYcI5CrSMvp kjEsAY7Oyz53zfZiBPFWWLrdRBEAnhQ5qteKe/t7Jq7zh9JbDuz3mBfLWmWBHCCY0RPL cx2532ZbaIvW75gBwMNpo96au3E5YAfYU2o8wWQ6uwdZe/A1dtX01gTPUVE79iStUfGY EhKPSmtO3ORP4+pOCYFnrZj5T/iKcXcrGBbr+1mDl387WCV3uqyPrRe/OZ9fRohI3Qs1 ojzZ6GPW58On00dL583j7OW5dqLKSsGdR70NbKEyxEcEWlyJa1d7jfHKqGVqNymgmvGF AJNg== X-Gm-Message-State: AOAM5337BNovgxkZ9QavHCYuHjE0ZKl6yz6HT6f1UfU5VxjWrQmX0+Bz cYy0Eme0sNgTnlL5JIl8sxs= X-Google-Smtp-Source: ABdhPJztkx7WA+cZA3Doz6c64U8sDkITSNhY1Ptpem58i2jTHpYhdjYrOu1ZfCKOMhfp2MK+3NQg2A== X-Received: by 2002:a17:90a:7:b0:1c7:c286:abc2 with SMTP id 7-20020a17090a000700b001c7c286abc2mr3209561pja.65.1650103816466; Sat, 16 Apr 2022 03:10:16 -0700 (PDT) Received: from localhost ([134.73.240.160]) by smtp.gmail.com with ESMTPSA id o123-20020a634181000000b0039d300c417dsm6699278pga.64.2022.04.16.03.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Apr 2022 03:10:15 -0700 (PDT) From: Ihor Radchenko To: Jamie Matthews Subject: Re: [PATCH] Re: [BUG] org-cite: 10 second hang opening a ~4k org file with 10MB bibtex library In-Reply-To: <877d8qf9k8.fsf@localhost> References: <87pmmifirh.fsf@localhost> <87fsnefg8b.fsf@localhost> <87cziifeo4.fsf@localhost> <87a6dmfd89.fsf@localhost> <877d8qf9k8.fsf@localhost> Date: Sat, 16 Apr 2022 18:11:09 +0800 Message-ID: <878rs5nxs2.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "emacs-orgmode@gnu.org" , Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650103892; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/FF1R7iqXavNOY/ntMplStRcZqxDjKqbnWMuQ3bEXyI=; b=fQipxv/cqbMefC90ovIzQvZGm+LLj0HPiT0SWZ7k0Jqjo1T/0gtw7eF/V788I5FzfB/PAW 8GxjfLRfAPiJWD6xDSEB61+MxoCBH9GeT3qdOgVF93Q7CD1mlTFrIBl3PQCUa+3f5VkCD9 4xM2y+wylpFmWs4wLtkbB0Dh9vGJ1yXK7x4cbL0HcXRyYyfPvc4jb6cTcwB6L/FNLN0Yfu aJZGH2UmlnxXwd8RBuLzpeh6FkXWmP7dAhJyR7DuUtQAD7v1nD1boYo6JpOJnZoE93pH0w 6qzayP/GjeiZCy/hfw9sH4c3zwUTA4qPpQ3J73mN/+EBjaHFw+8YU3VNNT0OKw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650103892; a=rsa-sha256; cv=none; b=XksCUB4tW1pGxnDT5ldwGKeq6WbqRo3DF90YjprcRFj5uwpUh8/LZ4ECeuk02pL85Mb579 1ZAZm2Al0gWx81xDNrSe/q3tIZqgbDPVPuieKa/+c/5MIY3IHxJVmkwnt6bdrp8cZ7q29M qgtelck5thAO1bD97akJpS4yV6FY9vPsYU3/+AwqSoZVsrAEaJE22Dseg0fLfPZ5/JKWgU b31nPD3qa2VroBOvMBUSU1VEqg42dze40ji9A+07G4l9l3B/LdnTQGdWYCy0fktYcozlX3 4jPrlX0OkfjfthtR6iJi2kP2UJUCni7/LvXyHzwaR5AxYuGdUjnV5bB1g4ntOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=aZysvKE0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=aZysvKE0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4A9B72D753 X-Spam-Score: 6.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: lm0FqsaNXrxP Ihor Radchenko writes: > Jamie Matthews writes: > >> I can confirm that the key turns red on insert when I altered the key outside of emacs (with that second version of `org-cite-basic--parse-bibliography`). > > Great. Then, I am attaching the patch with the new version of the > function. I will let Nicolas decide if it is good enough to be merged. I > do not feel confident enough with org-cite code to judge if my approach > is not missing some edge cases. It has been almost one month since I posted the patch. I took a freedom to merge it (+ one more extra optimisation) given the feedback and other complaints about oc-basic performance (e.g. By Prof. Kitchin). Best, Ihor