From: Ihor Radchenko <yantar92@gmail.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Delete some Emacs 24 compat code
Date: Thu, 30 Jun 2022 21:36:57 +0800 [thread overview]
Message-ID: <878rpe6znq.fsf@localhost> (raw)
In-Reply-To: <CADwFkm=qOEFUhOyYkK0Jy8dXj9-X0kFwL2E-UOM3KBd4sp7kSA@mail.gmail.com>
Stefan Kangas <stefan@marxist.se> writes:
> The attached patch deletes some Emacs 24 compat code. Org mode
> supports Emacs 26 or later, according to:
> https://orgmode.org/worg/org-maintenance.html#emacs-compatibility
Thanks! I have some comments.
> ;;; Integration with and fixes for other packages
> diff --git a/lisp/org-fold-core.el b/lisp/org-fold-core.el
> index 88072852d..287686c01 100644
> --- a/lisp/org-fold-core.el
> +++ b/lisp/org-fold-core.el
> ...
> +(define-obsolete-function-alias 'org-fold-core--seq-partition #'seq-partition "9.6")
> diff --git a/lisp/org-macs.el b/lisp/org-macs.el
> index da68d8b8f..07c177b0b 100644
> --- a/lisp/org-macs.el
> +++ b/lisp/org-macs.el
> @@ -70,18 +70,7 @@
> ...
> +(define-obsolete-function-alias 'org-without-partial-completion 'progn "9.6")
^#'progn
We usually put obsolete aliases into org-compat.el instead of sprinkling
them across the various .el files. Please move the
define-obsolete-function-alias statements to org-compat.
Best,
Ihor
next prev parent reply other threads:[~2022-06-30 13:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:19 [PATCH] Delete some Emacs 24 compat code Stefan Kangas
2022-06-30 13:36 ` Ihor Radchenko [this message]
2022-06-30 13:39 ` Ihor Radchenko
2022-06-30 15:25 ` Stefan Kangas
2022-07-02 4:11 ` Ihor Radchenko
2022-06-30 15:25 ` Max Nikulin
2022-06-30 15:47 ` Ihor Radchenko
2022-06-30 22:46 ` Samuel Wales
2022-07-01 2:45 ` Ihor Radchenko
2022-07-01 3:11 ` Samuel Wales
2022-07-01 4:00 ` Tim Cross
2022-07-01 4:44 ` Samuel Wales
2022-07-17 9:35 ` Bastien Guerry
2022-07-18 1:23 ` Samuel Wales
2022-07-31 12:54 ` Ihor Radchenko
2022-08-08 15:46 ` Bastien
2022-08-08 22:12 ` Tim Cross
2022-08-09 0:41 ` Bastien
2022-08-10 11:50 ` Ihor Radchenko
2022-08-11 10:23 ` Bastien
2022-08-11 11:53 ` Ihor Radchenko
2022-08-12 6:30 ` Bastien
2022-08-09 15:58 ` Max Nikulin
2022-08-10 0:06 ` Tim Cross
2022-08-10 0:59 ` Tom Gillespie
2022-08-10 1:13 ` Tim Cross
2022-08-10 4:55 ` Tom Gillespie
2022-08-10 14:18 ` Tim Cross
2022-08-11 2:59 ` Samuel Wales
2022-08-11 5:34 ` Tim Cross
2022-08-11 5:56 ` Tim Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rpe6znq.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).