From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0Lx+IRhh6GSACwAASxT56A (envelope-from ) for ; Fri, 25 Aug 2023 10:06:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MI+DIRhh6GTOHwEA9RJhRA (envelope-from ) for ; Fri, 25 Aug 2023 10:06:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A4993F396 for ; Fri, 25 Aug 2023 10:06:48 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=jbloB0+P; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692950808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=O2uXjWicHMYyTp64DPlPZ/18Qs6l30b8tODrqn5tbzc=; b=IuaprIhCcTR0N8GX2/JBayFQqp6kf2aw9o2+MXU/q4Hele/bi6YAw0m6ZY16TxgvhvXZRO wVjjh7s+a7LCDhdyJmBVXEFqLJMo0CiH/8VSIkVMP5qe7NWfyh2yX/RzwNQnUB1i6fuwBH vLHEPlBrfNXPqQV+sgqfSPZ10of0ydsP4LE9Jt3uObafulqVENvl8GPTcHybVgqj/1AWMU 90FbbsCha131cyl3Jv4kmWwU62rkZWeEfnQru6hXxP/OCffcGxqld5+mVETyZUnBvladUS uWOXiK+bPDwQeulMBQPtpH3WHBrL9S+sO1dxx5QqVltLNP8A1qH5bH9vI3I5zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=jbloB0+P; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692950808; a=rsa-sha256; cv=none; b=ICe3CrtzhMNHAXov6frRkr/5GQplcd6dGL16nPhqmR7k5UoHca+yPD28rDq16zoICMYfwD ckdBwn370Hsjhev/pHRX2tumoMdtwcq0dSwmX12R33aq/3ad5Qbf85oq1+2ZXBigdG+Lxz jhNfSFnsRBTpaO0FZpuxcWwKc+OBERZag03Zybae7Zm5AyaWybQGb4uGaoSDhsXWYrmxau Ozz0vWwNoE6EfqdV2+vKdi+e3Ai+VpgfIaPfcA/UltVt3FhIBUT3/+/ZDf2tZ1vWSBHlZ0 NXw2AFVpd/gb08A7d33ZbZHk+s0WyEOBxoCpC69yJrQvDck4kGnNQ2T9veVI8Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZRpU-0007fq-Fw; Fri, 25 Aug 2023 04:06:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZRpM-0007fe-5c for emacs-orgmode@gnu.org; Fri, 25 Aug 2023 04:05:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZRpJ-0003XA-Ah for emacs-orgmode@gnu.org; Fri, 25 Aug 2023 04:05:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 60355240028 for ; Fri, 25 Aug 2023 10:05:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692950751; bh=U7YTJbxtJ4iw5dUlsc0AoFFejP6+2O6Jq8FFxVPIJvE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=jbloB0+Pa0ONeODV/kiTIU3GFWbwHuFBD+wuApcb/XppzD1UFxyJYaMHMDohYaFqp a1wP/1ywyVdOjVJTxy4ln1A4KlJ+1clWEp8NpauZE7uJVJ73+1lLYHVxtoB1q7ft6n cUdzqty2wKOHDpCqr2dnhJ4ItHfZyiiFDGNkg6tSu+UrSSS8stvhvdLa52qIqW/e18 xoZLznkoFh6JBfM54mHgGoYGsVTcQdvVTwb5TZ1Qq6c1eRrwyi4qnhw+IotgK4BFzl u+2/ZEY7LKkAiz7/mt3aqXC9mnnmGhDrCmPVObF+j67GY/Q5QuoI3vH2aiVeaYMg/F 9viziwC3EXwNQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RXCFB4wF3z6twH; Fri, 25 Aug 2023 10:05:50 +0200 (CEST) From: Ihor Radchenko To: No Wayman Cc: emacs-orgmode@gnu.org Subject: Re: Org mode version 9.7-pre (9.7-pre-n/a-g63e8ca @ /home/n/.emacs.d/elpaca/builds/org/); [PATCH] refactor org-babel-lilypond-compile-lilyfile In-Reply-To: <87jztk1rdc.fsf@gmail.com> References: <87jztk1rdc.fsf@gmail.com> Date: Fri, 25 Aug 2023 08:06:20 +0000 Message-ID: <878r9zim0z.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -9.18 X-Spam-Score: -9.18 X-Migadu-Queue-Id: 6A4993F396 X-TUID: SHX52FK++fFB No Wayman writes: > The attached patch: > > - Improves the compilation message. (The target is the file, not > LilyPond itself). > - Refactors the body of the function to remove the many > nondescript arg-n local variables. Thanks! LGTM. > - Removes the optional TEST parameter, which is unused and better > served through debugging tools. This is technically a breaking change. So, we (1) need to mention it in ORG-NEWS; (2) may consider (file-name &optional _) function definition to be 100% sure that no existing code will be broken. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at