From: Suhail Singh <suhailsingh247@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Suhail Singh <suhailsingh247@gmail.com>,
TEC <orgmode@tec.tecosaur.net>,
Org mailing list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks
Date: Mon, 22 Jul 2024 15:35:25 -0400 [thread overview]
Message-ID: <878qxt2paa.fsf@gmail.com> (raw)
In-Reply-To: <877cddmedg.fsf@localhost> (Ihor Radchenko's message of "Mon, 22 Jul 2024 19:10:51 +0000")
Ihor Radchenko <yantar92@posteo.net> writes:
> AFAIU, your main point is that you want the patch to land on bugfix. It
> will not, regardless whether we add :textarea support or not.
While not the answer I had hoped for, I appreciate the clarification.
> Next, if you are not interested in adding :textarea support, it is
> OK. Adding #+ATTR_HTML support for code blocks and fixed width elements
> will still be a welcome improvement (I was just hoping to push you to
> contribute a bit more ;))
>
> Now, back to your original patch.
> May you please factor out adding attributes into a separate function, so
> that we avoid duplicating the code? And please announce the change in
> the news - people aware of the current behavior might need to know about
> the change.
Given that I already have some contributions in Org mode and I don't, at
present, intend to do the copyright assignment to FSF, could you please
confirm:
1. How many lines worth of changes I can still introduce without going
over the limit?
2. When implementing such refactoring changes, which lines are counted?
From a feasibility perspective, I suspect it might be better for you (or
someone else who's signed the FSF copyright assignment paperwork) to
take on the work of applying changes that are similar in spirit to the
patch.
--
Suhail
next prev parent reply other threads:[~2024-07-22 19:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 2:55 [PATCH] [BUG] Support attr_html in source code and fixed-width blocks Suhail Singh
2024-06-18 15:33 ` Ihor Radchenko
2024-07-19 15:28 ` Suhail Singh
2024-07-22 13:49 ` Ihor Radchenko
2024-07-22 17:11 ` Suhail Singh
2024-07-22 18:13 ` Ihor Radchenko
2024-07-22 18:45 ` Suhail Singh
2024-07-22 19:10 ` Ihor Radchenko
2024-07-22 19:35 ` Suhail Singh [this message]
2024-07-22 19:49 ` Ihor Radchenko
2024-07-22 20:05 ` Suhail Singh
2024-09-02 13:03 ` Suhail Singh
2024-09-07 18:10 ` Ihor Radchenko
2024-09-07 19:45 ` Suhail Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qxt2paa.fsf@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=orgmode@tec.tecosaur.net \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).