emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Recognize underscores in URL
@ 2010-08-12 17:59 Nicolas Goaziou
  2010-08-23 11:40 ` Carsten Dominik
  2010-08-25 10:33 ` [Accepted] " Carsten Dominik
  0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2010-08-12 17:59 UTC (permalink / raw)
  To: Org Mode List

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hello,

This needs some testing as it may break something else, but the
following patch should prevent underscores in URL from introducing
subscript.

Regards,

-- Nicolas


[-- Attachment #2: 0001-Recognize-URL-with-underscores.patch --]
[-- Type: text/plain, Size: 969 bytes --]

From dd068df8a0e43a1a4ee85559bddb7ef2dbfa72bd Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <n.goaziou@gmail.com>
Date: Thu, 12 Aug 2010 19:47:29 +0200
Subject: [PATCH] Recognize URL with underscores

* org.el (org-make-link-regexps): modified regexp of org-plain-link-re.
---
 lisp/org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 31d2411..4560488 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -4851,7 +4851,7 @@ This should be called after the variable `org-link-types' has changed."
 	org-plain-link-re
 	(concat
 	 "\\<\\(" (mapconcat 'regexp-quote org-link-types "\\|") "\\):"
-	 (org-re "\\([^ \t\n()<>]+\\(?:([[:word:]0-9]+)\\|\\([^[:punct:] \t\n]\\|/\\)\\)\\)"))
+	 (org-re "\\([^ \t\n()<>]+\\(?:([[:word:]0-9_]+)\\|\\([^[:punct:] \t\n]\\|/\\)\\)\\)"))
 	;;	 "\\([^]\t\n\r<>() ]+[^]\t\n\r<>,.;() ]\\)")
 	org-bracket-link-regexp
 	"\\[\\[\\([^][]+\\)\\]\\(\\[\\([^][]+\\)\\]\\)?\\]"
-- 
1.7.2.1


[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Recognize underscores in URL
  2010-08-12 17:59 [PATCH] Recognize underscores in URL Nicolas Goaziou
@ 2010-08-23 11:40 ` Carsten Dominik
  2010-08-23 13:46   ` Nicolas Goaziou
  2010-08-25 10:33 ` [Accepted] " Carsten Dominik
  1 sibling, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-08-23 11:40 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Org Mode List

Hi Nicolas,

can you please remind me why this would be necessary?

Thanks!

- Carsten
On Aug 12, 2010, at 7:59 PM, Nicolas Goaziou wrote:

> Hello,
>
> This needs some testing as it may break something else, but the
> following patch should prevent underscores in URL from introducing
> subscript.
>
> Regards,
>
> -- Nicolas
>
> <0001-Recognize-URL-with- 
> underscores.patch>_______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Recognize underscores in URL
  2010-08-23 11:40 ` Carsten Dominik
@ 2010-08-23 13:46   ` Nicolas Goaziou
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2010-08-23 13:46 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: Org Mode List

Hello,

>>>>> Carsten Dominik writes:
> can you please remind me why this would be necessary?

It _should_ allow to correctly fontify and export URL such as this
one:

http://en.wikipedia.org/wiki/Lisp_(programming_language)

Regards,

-- Nicolas

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Accepted] Recognize underscores in URL
  2010-08-12 17:59 [PATCH] Recognize underscores in URL Nicolas Goaziou
  2010-08-23 11:40 ` Carsten Dominik
@ 2010-08-25 10:33 ` Carsten Dominik
  2010-08-25 10:35   ` Carsten Dominik
  1 sibling, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-08-25 10:33 UTC (permalink / raw)
  To: emacs-orgmode

Patch 214 (http://patchwork.newartisans.com/patch/214/) is now "Accepted".

Maintainer comment: Tanks

This relates to the following submission:

http://mid.gmane.org/%3C877hjv90fo.wl%25n.goaziou%40gmail.com%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Recognize underscores in URL
> Date: Thu, 12 Aug 2010 22:59:39 -0000
> From: Nicolas Goaziou <n.goaziou@gmail.com>
> X-Patchwork-Id: 214
> Message-Id: <877hjv90fo.wl%n.goaziou@gmail.com>
> To: Org Mode List <emacs-orgmode@gnu.org>
> 
> Hello,
> 
> This needs some testing as it may break something else, but the
> following patch should prevent underscores in URL from introducing
> subscript.
> 
> Regards,
> 
> -- Nicolas
> >From dd068df8a0e43a1a4ee85559bddb7ef2dbfa72bd Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <n.goaziou@gmail.com>
> Date: Thu, 12 Aug 2010 19:47:29 +0200
> Subject: [PATCH] Recognize URL with underscores
> 
> * org.el (org-make-link-regexps): modified regexp of org-plain-link-re.
> 
> ---
> lisp/org.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index 31d2411..4560488 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -4851,7 +4851,7 @@ This should be called after the variable `org-link-types' has changed."
>  	org-plain-link-re
>  	(concat
>  	 "\\<\\(" (mapconcat 'regexp-quote org-link-types "\\|") "\\):"
> -	 (org-re "\\([^ \t\n()<>]+\\(?:([[:word:]0-9]+)\\|\\([^[:punct:] \t\n]\\|/\\)\\)\\)"))
> +	 (org-re "\\([^ \t\n()<>]+\\(?:([[:word:]0-9_]+)\\|\\([^[:punct:] \t\n]\\|/\\)\\)\\)"))
>  	;;	 "\\([^]\t\n\r<>() ]+[^]\t\n\r<>,.;() ]\\)")
>  	org-bracket-link-regexp
>  	"\\[\\[\\([^][]+\\)\\]\\(\\[\\([^][]+\\)\\]\\)?\\]"
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Accepted] Recognize underscores in URL
  2010-08-25 10:33 ` [Accepted] " Carsten Dominik
@ 2010-08-25 10:35   ` Carsten Dominik
  0 siblings, 0 replies; 5+ messages in thread
From: Carsten Dominik @ 2010-08-25 10:35 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: emacs-orgmode


On Aug 25, 2010, at 12:33 PM, Carsten Dominik wrote:

> Patch 214 (http://patchwork.newartisans.com/patch/214/) is now  
> "Accepted".
>
> Maintainer comment: Tanks

Arrgh!  THANKS!

>
> This relates to the following submission:
>
> http://mid.gmane.org/%3C877hjv90fo.wl%25n.goaziou%40gmail.com%3E
>
> Here is the original message containing the patch:
>
>> Content-Type: text/plain; charset="utf-8"
>> MIME-Version: 1.0
>> Content-Transfer-Encoding: 7bit
>> Subject: [Orgmode] Recognize underscores in URL
>> Date: Thu, 12 Aug 2010 22:59:39 -0000
>> From: Nicolas Goaziou <n.goaziou@gmail.com>
>> X-Patchwork-Id: 214
>> Message-Id: <877hjv90fo.wl%n.goaziou@gmail.com>
>> To: Org Mode List <emacs-orgmode@gnu.org>
>>
>> Hello,
>>
>> This needs some testing as it may break something else, but the
>> following patch should prevent underscores in URL from introducing
>> subscript.
>>
>> Regards,
>>
>> -- Nicolas
>>> From dd068df8a0e43a1a4ee85559bddb7ef2dbfa72bd Mon Sep 17 00:00:00  
>>> 2001
>> From: Nicolas Goaziou <n.goaziou@gmail.com>
>> Date: Thu, 12 Aug 2010 19:47:29 +0200
>> Subject: [PATCH] Recognize URL with underscores
>>
>> * org.el (org-make-link-regexps): modified regexp of org-plain-link- 
>> re.
>>
>> ---
>> lisp/org.el |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 31d2411..4560488 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -4851,7 +4851,7 @@ This should be called after the variable `org- 
>> link-types' has changed."
>> 	org-plain-link-re
>> 	(concat
>> 	 "\\<\\(" (mapconcat 'regexp-quote org-link-types "\\|") "\\):"
>> -	 (org-re "\\([^ \t\n()<>]+\\(?:([[:word:]0-9]+)\\|\\([^[:punct:]  
>> \t\n]\\|/\\)\\)\\)"))
>> +	 (org-re "\\([^ \t\n()<>]+\\(?:([[:word:]0-9_]+)\\|\\([^[:punct:]  
>> \t\n]\\|/\\)\\)\\)"))
>> 	;;	 "\\([^]\t\n\r<>() ]+[^]\t\n\r<>,.;() ]\\)")
>> 	org-bracket-link-regexp
>> 	"\\[\\[\\([^][]+\\)\\]\\(\\[\\([^][]+\\)\\]\\)?\\]"
>>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-08-25 10:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-12 17:59 [PATCH] Recognize underscores in URL Nicolas Goaziou
2010-08-23 11:40 ` Carsten Dominik
2010-08-23 13:46   ` Nicolas Goaziou
2010-08-25 10:33 ` [Accepted] " Carsten Dominik
2010-08-25 10:35   ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).