From: Dan Davison <dandavison7@gmail.com>
To: emacs org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: [BABEL] Two minor issues
Date: Mon, 22 Nov 2010 14:20:06 +0000 [thread overview]
Message-ID: <877hg5qw2x.fsf@gmail.com> (raw)
In-Reply-To: <80k4k5yabd.fsf@missioncriticalit.com> ("Sébastien Vauban"'s message of "Mon, 22 Nov 2010 10:30:46 +0100")
Sébastien Vauban <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
writes:
> Hi Dan,
>
> (resending this, as it seems to never have reached the ML)
Could you tell me what I should do with the random characters in the
addresses that appear in your emails? I've deleted the addresses and
just sending to emacs-orgmode@gnu.org, is that OK?
> Dan Davison wrote:
>> Sébastien Vauban writes:
>>> Dan Davison wrote:
<...>
> Honestly, the way I update that code has been mainly done by sequences of
> trials and errors. The above code is, for me, still quite complex to
> understand with vars such as beg, beg1, end, end1 for which I hadn't
> completely understood the meaning.
This seems to work -- could you try it out?
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org.el b/lisp/org.el
index e2de48e..0b082da 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5102,9 +5102,6 @@ will be prompted for."
(add-text-properties
beg end
'(font-lock-fontified t font-lock-multiline t))
- (add-text-properties beg beg1 '(face org-meta-line))
- (add-text-properties end1 (+ end 1) '(face org-meta-line))
- ; for end_src
(cond
((and lang org-src-fontify-natively)
(org-src-font-lock-fontify-block lang block-start block-end))
@@ -5117,6 +5114,8 @@ will be prompted for."
(add-text-properties beg1 end1 '(face org-quote)))
((string= block-type "verse")
(add-text-properties beg1 end1 '(face org-verse))))
+ (add-text-properties beg beg1 '(face org-meta-line))
+ (add-text-properties (1+ end) (1+ end1) '(face org-meta-line))
t))
((member dc1 '("title:" "author:" "email:" "date:"))
(add-text-properties
--8<---------------cut here---------------end--------------->8---
Dan
> Otherwise, I would even have proposed a
> renaming of some of them. But, I think that whatever we do, such a code will
> stay complex to understand and change.
>
> Find here a picture of what we see (since my patch) without native
> fontification.
>
> http://www.mygooglest.com/sva/No-Native-Fontification.png
>
> Also, a picture with the "new" setting of native fontification.
>
> http://www.mygooglest.com/sva/Native-Fontification-Minibug.png
>
> Hope this helps. If you need help, I'm willing to take a look back a it (still
> trying and testing the effect of changes), but it won't be before a couple of
> days.
>
> Best regards,
> Seb
next prev parent reply other threads:[~2010-11-22 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 10:58 [BABEL] Two minor issues Jambunathan K
2010-11-20 0:07 ` Dan Davison
2010-11-20 7:19 ` Sébastien Vauban
2010-11-20 13:05 ` Dan Davison
2010-11-22 9:30 ` Sébastien Vauban
2010-11-22 14:20 ` Dan Davison [this message]
2010-11-22 20:14 ` Sébastien Vauban
2010-11-22 21:36 ` Sébastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hg5qw2x.fsf@gmail.com \
--to=dandavison7@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).