emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Manuel Giraud <manuel.giraud@univ-nantes.fr>
To: emacs-orgmode@gnu.org
Subject: Re: [REGRESSION] org-html.el (targets)
Date: Mon, 07 Mar 2011 17:15:21 +0100	[thread overview]
Message-ID: <877hcarjom.fsf@univ-nantes.fr> (raw)
In-Reply-To: <81r5b2frh9.fsf@gmail.com> (Jambunathan K.'s message of "Mon, 21 Feb 2011 00:44:42 +0530")

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Jambunathan K <kjambunathan@gmail.com> writes:

> I am attaching the bug.org file and the html exports as done by git
> versions 048f32 (approx a month old) and 77c278 (very recent).

Hi,

Here's a patch that fixes this issue.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-html.el-bug-that-prevents-some-target-to-be-rend.patch --]
[-- Type: text/x-patch, Size: 1548 bytes --]

From cd423f908de55a2379c4476c0da8922968786e64 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel.giraud@univ-nantes.fr>
Date: Mon, 7 Mar 2011 17:12:46 +0100
Subject: [PATCH] org-html.el: bug that prevents some target to be rendered correctly.

---
 lisp/org-exp.el  |    2 +-
 lisp/org-html.el |   10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/org-exp.el b/lisp/org-exp.el
index ae7bdcf..f22eeba 100644
--- a/lisp/org-exp.el
+++ b/lisp/org-exp.el
@@ -2062,7 +2062,7 @@ can work correctly."
     (let* ((rtn
 	    (mapconcat
 	     'identity
-	     (org-split-string s "[^a-zA-Z0-9_\\.-]+") "--"))
+	     (org-split-string s "[^a-zA-Z0-9_\\.-]+") "-"))
 	   (a (assoc rtn alist)))
       (or (cdr a) rtn))))
 
diff --git a/lisp/org-html.el b/lisp/org-html.el
index eb4b199..8fe8029 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -2181,12 +2181,12 @@ that uses these same face definitions."
 (defun org-html-protect (s)
   "Convert characters to HTML equivalent.
 Possible conversions are set in `org-export-html-protect-char-alist'."
-  (let ((start 0)
-	(cl org-export-html-protect-char-alist) c)
+  (let ((cl org-export-html-protect-char-alist) c)
     (while (setq c (pop cl))
-      (while (string-match (car c) s start)
-	(setq s (replace-match (cdr c) t t s)
-	      start (1+ (match-beginning 0)))))
+      (let ((start 0))
+	(while (string-match (car c) s start)
+	  (setq s (replace-match (cdr c) t t s)
+		start (match-beginning 0)))))
     s))
 
 (defun org-html-expand (string)
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 33 bytes --]


Best regards,
-- 
Manuel Giraud

  reply	other threads:[~2011-03-07 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-20 19:14 [REGRESSION] org-html.el (targets) Jambunathan K
2011-03-07 16:15 ` Manuel Giraud [this message]
2011-03-07 20:37   ` Bernt Hansen
2011-03-08  7:14     ` Aankhen
2011-03-08 10:15       ` Manuel Giraud
2011-03-08 15:02         ` Bernt Hansen
2011-03-09 10:39         ` Bastien
2011-03-09 10:40           ` Bastien
2011-03-09 15:06             ` Manuel Giraud
2011-03-09 15:38               ` [Accepted] [O] " Bastien Guerry
2011-03-09 15:40               ` Bastien
2011-03-09 10:36       ` Bastien
2011-03-09 19:27         ` Aankhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hcarjom.fsf@univ-nantes.fr \
    --to=manuel.giraud@univ-nantes.fr \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).