emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Nicolas Girard <girard.nicolas@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 1/2] Simplify org-clocktable-indent-string.
Date: Fri, 20 Apr 2012 13:12:07 +0200	[thread overview]
Message-ID: <877gxa1wu0.fsf@altern.org> (raw)
In-Reply-To: <1333238367-27755-1-git-send-email-girard.nicolas@gmail.com> (Nicolas Girard's message of "Sun, 1 Apr 2012 01:59:26 +0200")

Hi Nicolas,

Nicolas Girard <girard.nicolas@gmail.com> writes:

> ---
>  lisp/org-clock.el |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 591f59c..be66ce6 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -2342,11 +2342,7 @@ from the dynamic block definition."
>  (defun org-clocktable-indent-string (level)
>    (if (= level 1)
>        ""
> -    (let ((str "\\__"))
> -      (while (> level 2)
> -	(setq level (1- level)
> -	      str (concat str "___")))
> -      (concat str " "))))
> +    (concat "\\" (make-string (* 2 (1- level)) ?_ ) " ")))
>  
>  (defun org-clocktable-steps (params)
>    "Step through the range to make a number of clock tables."

The "simplification" does not produce the same output.

I rejected this patch.

-- 
 Bastien

      parent reply	other threads:[~2012-04-20 11:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <girard.nicolas@gmail.com>
2012-03-30 19:43 ` [PATCH] Allow org-collector to display heading indentation Nicolas Girard
2012-03-30 19:52   ` Achim Gratz
2012-03-30 19:52   ` Nick Dokos
2012-03-30 20:55     ` Nicolas Girard
2012-03-31  6:57       ` Sebastien Vauban
2012-03-31 23:58         ` Nicolas Girard
2012-03-31 23:59         ` [PATCH 1/2] Simplify org-clocktable-indent-string Nicolas Girard
2012-03-31 23:59           ` [PATCH 2/2] Allow org-collector to display heading indentation by passing ':indent t' to the propview block Nicolas Girard
2012-04-02 16:56             ` Bastien
2012-04-20 11:12             ` Bastien
2012-04-20 11:12           ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gxa1wu0.fsf@altern.org \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=girard.nicolas@gmail.com \
    --subject='Re: [PATCH 1/2] Simplify org-clocktable-indent-string.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).