emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Myles English <mylesenglish@gmail.com>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>,
	Nick Dokos <nicholas.dokos@hp.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-e-latex: Tables get correct amount of vertical	space
Date: Tue, 13 Nov 2012 21:31:31 +0000	[thread overview]
Message-ID: <877gppqjf0.fsf@gmail.com> (raw)
In-Reply-To: <801ufxscmi.fsf@somewhere.org>

Sebastien Vauban writes:

> Hi Myles and Nick,
> Nick Dokos wrote:
>> Myles English <mylesenglish@gmail.com> wrote:
>>> Sebastien Vauban writes:
>>> > Myles English wrote:
>>> >> This patch replaces every occurence of the \begin{center} environment
>>> >> with \centering in the file contrib/lisp/org-e-latex.el.
>>> >> ...
>>> >> -   (format "\\begin{center}\n%s\\end{center}" contents)))
>>> >> +   (format "\\centering\n%s" contents)))
>>> >
>>> > Wouldn't you have to replace
>>> >
>>> >   \begin{center}
>>> >     ...
>>> >   \end{center}
>>> >
>>> > by
>>> >
>>> >   {\centering
>>> >     ...
>>> >   }
>>> >
>>> > ?  That is, add a group around?
>>> I don't think so, at least I have not come across that usage, and it
>>> seems to work without.  Do you know different?
>> If a \centering occurs at top-level in a latex document,
>> then *everything* after it will be centered: it's a declaration that
>> remains in force for the current group (which is the rest of the
>> document if it occurs at top-level).
> As confirmed by Nick, \centering just changes the layout for ever... up to the
> end of the document.
> Why does it work?  I guess because there are grouping commands inserted by Org
> at other places, that stop the propagation of the centering that far... But
> it's dangerous to count on them, IMHO.
>> \begin{center}...\end{center} is essentially {\centering ...} except
>> that it also starts a new paragraph.

From within a figure or table environment, that new paragraph shows up
as uneeded vertical space, see the example I give lower down.

>> It's not clear to me at least, that wholesale replacement is the correct
>> thing to do: it needs to be looked at on a case-by-case basis I
>> think.

Nick, I think you are right about this, the modified patch at the end of
this email makes only the replacements that are necessary just to
replace the center environment within table blocks.

The other \begin{center}'s in the org-e-latex.el file may be changed
some other time, if needed.

> I think that's a safe replacement (_with_ the grouping), and with something I
> forgot about (well seen Nick!): the \par.

I don't think the grouping is necessary because the implied group will
be closed when the table environment is ended.  Likewise, I don't think
the \par is necessary.

If you compile this this latex it illustrates the problem, and the

%______________________________begin example.tex_______________



A & B\\



A & B\\

%______________________________end example.tex_______________

> See, for example,
> https://groups.google.com/forum/?fromgroups=#!topic/fr.comp.text.tex/0s4WfsIfmy8
> for the answer of Manuel Pégourié-Gonnard, one reference wrt LaTeX
> questions:

My French, and my browser apparently, is not good enough to understand
that thread.  Sorry.  Please translate if it is still relevant to this

>   "replace the environment by {\centering ... \par}"

[answered above]

> Best regards,
>   Seb


From 51686ada4cb2560eb5dfb6b445af547eccff8bff Mon Sep 17 00:00:00 2001
From: Myles English <mylesenglish@gmail.com>
Date: Tue, 13 Nov 2012 21:04:16 +0000
Subject: [PATCH] org-e-latex:  Tables get correct amount of vertical space

* contrib/lisp/org-e-latex.el: Replaced a set of \begin{center}
  and \end{center} environment markers with a \centering

Using both \begin{table} and \being{center} environments leads to double
the vertical space around the float, whereas \centering adds none.

 contrib/lisp/org-e-latex.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/contrib/lisp/org-e-latex.el b/contrib/lisp/org-e-latex.el
index 165beb3..5635c6a 100644
--- a/contrib/lisp/org-e-latex.el
+++ b/contrib/lisp/org-e-latex.el
@@ -2302,14 +2302,13 @@ This function assumes TABLE has `org' as its `:type' attribute."
 		   (format "\\begin{%s}%s\n" float-env placement)
 		   (if org-e-latex-table-caption-above caption "")))
-		(when org-e-latex-tables-centered "\\begin{center}\n")
+		(when org-e-latex-tables-centered "\\centering\n")
 		(format "\\begin{%s}%s{%s}\n%s\\end{%s}"
 			(if width (format "{%s}" width) "")
-		(when org-e-latex-tables-centered "\n\\end{center}")
 		(when float-env
 		  (concat (if org-e-latex-table-caption-above "" caption)
 			  (format "\n\\end{%s}" float-env))))))))

  parent reply	other threads:[~2012-11-13 21:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13 14:29 [PATCH] org-e-latex: Tables get correct amount of vertical space Myles English
2012-11-13 14:54 ` Sebastien Vauban
2012-11-13 15:05   ` Myles English
2012-11-13 15:56     ` Nick Dokos
2012-11-13 16:15       ` Sebastien Vauban
2012-11-13 16:20         ` Nick Dokos
2012-11-13 16:32           ` Nick Dokos
2012-11-14  8:44             ` Sebastien Vauban
2012-11-14  9:40               ` Myles English
2012-11-13 21:31         ` Myles English [this message]
2012-11-14 14:03           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gppqjf0.fsf@gmail.com \
    --to=mylesenglish@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=nicholas.dokos@hp.com \
    --cc=wxhgmqzgwmuf@spammotel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).