emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Bill Wishon <bill@wishon.org>, schulte eric <schulte.eric@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Fix to property inheritance
Date: Mon, 07 Jan 2013 18:35:42 +0100	[thread overview]
Message-ID: <877gnoc2g8.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CAP2uJAsiGkezGx6YnVFPcrWVOv2ChsKBH0zkcD+pA=hspSyh1A@mail.gmail.com> (Bill Wishon's message of "Sat, 15 Dec 2012 22:24:30 -0800")

Hi Bill,

sorry for the late (and probably disappointing) reply.

Bill Wishon <bill@wishon.org> writes:

> This is my first major org-mode contribution, and I'm new to git, so
> if there is something I haven't got quite right in terms of how to
> contribute please advise.
>
> org-entry-get with inherit set didn't work for sub-heading additions
> or overrides to properties found in parent headings as of Org-mode
> version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can
> not be found!).  
>
> An example test org-mode file is attached (modified from the testing/
> examples directory and also updated in my git repository).

Thanks for providing such a file with tests and examples.  

As far as I understand, problems are for cumulative properties, 
right?  

Eric, do you have time to check Bill's tests and see what's 
wrong with cumulative properties and inheritance?  I'm not familiar
enough with this part of the code to *enjoy* fixing this :)

As for the patch themselves...

1) I did not receive confirmation from the FSF copyright clerk that
   your assignment is processed -- let me know if it is;

2) Please shrink commit messages and code lines to < 75 characters
   when possible.  See org.el: we avoid long lines.  This is not only
   for code readability, but also - and importantly here - for patch
   readability...

If I overlooked a bug about something else than cumulative props, 
please let me know and let's have a separate fix for it.

Thanks!

-- 
 Bastien

next prev parent reply	other threads:[~2013-01-07 17:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-16  6:24 Fix to property inheritance Bill Wishon
2012-12-24  0:45 ` Bastien
2012-12-25  3:28 ` Bastien
2012-12-26  1:00   ` Bill Wishon
2012-12-30 10:39     ` Bastien
2013-01-07 17:35 ` Bastien [this message]
2013-01-07 19:57   ` Bill Wishon
2013-01-07 20:10     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gnoc2g8.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=bill@wishon.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=schulte.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).