From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] fix org-insert-todo-heading-respect-content in plain list item Date: Mon, 28 Oct 2013 09:43:40 +0100 Message-ID: <877gcxbxab.fsf@gmail.com> References: <878uxeu0bh.fsf@acer.localhost.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaiQ8-000390-VD for emacs-orgmode@gnu.org; Mon, 28 Oct 2013 04:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VaiQ0-0000Z5-Ib for emacs-orgmode@gnu.org; Mon, 28 Oct 2013 04:43:32 -0400 Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:59156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaiQ0-0000Yy-Ak for emacs-orgmode@gnu.org; Mon, 28 Oct 2013 04:43:24 -0400 Received: by mail-we0-f182.google.com with SMTP id t61so6153028wes.41 for ; Mon, 28 Oct 2013 01:43:23 -0700 (PDT) In-Reply-To: <878uxeu0bh.fsf@acer.localhost.com> (Ingo Lohmar's message of "Sun, 27 Oct 2013 17:48:34 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ingo Lohmar Cc: emacs-orgmode@gnu.org Hello, Ingo Lohmar writes: > please find attached a 1-4-char patch fixing the behavior of the above > function when inside a plain list. [...] > Subject: [PATCH] fix org-insert-todo-heading-respect-content in plain list item > > * lisp/org.el (org-insert-todo-heading-respect-content): pass correct > prefix arg to always insert heading > > TINYCHANGE > > This function used a second argument t, which is eventually passed to > org-insert-heading, adding a list item when inside a plain list. Use > the proper argument '(4) now, to always create a heading, just like > the function's name and documentation imply. Thank you for your patch. Could you provide a test case, because, after a quick test, I do not see any difference before and after applying your patch. Regards, -- Nicolas Goaziou