From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yasushi SHOJI Subject: Re: [PATCH] org-plot: Handle explicit date/time index Date: Tue, 25 Mar 2014 06:37:45 +0900 Message-ID: <877g7jcm6u.wl@dns1.atmark-techno.com> References: <87ob1e2bin.wl@dns1.atmark-techno.com> <87bnwwhi52.fsf@bzg.ath.cx> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSCZH-0002H1-OQ for emacs-orgmode@gnu.org; Mon, 24 Mar 2014 17:38:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSCZC-0006Lx-SB for emacs-orgmode@gnu.org; Mon, 24 Mar 2014 17:38:03 -0400 In-Reply-To: <87bnwwhi52.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: bzg@gnu.org Cc: emacs-orgmode@gnu.org Hi Bastien, At Sun, 23 Mar 2014 19:41:45 +0100, Bastien wrote: > > Yasushi SHOJI writes: > > > * lisp/org-plot.el (org-plot-quote-tsv-field): Dump data as is when > > `timeind' is set. > > This change produces a compiler warning: > > In org-plot-quote-tsv-field: > org-plot.el:113:22:Warning: reference to free variable `params' Thank you for catching this. I guess I have to re-think the whole thing. The current code by-passes the quoting function for _all_ fields, not just for the index when `timeind' is present. This surely breaks for others. I don't have much time today. So, please give me a day or two. Meanwhile, Bastien, would you mind to revert the commit for me? Thanks, -- yashi