From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: org-review-schedule
Date: Sat, 19 Apr 2014 10:14:35 +0200
Message-ID: <877g6leltk.fsf@bzg.ath.cx>
References: <m2ppke1izt.fsf@polytechnique.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43940)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbR81-0006Wr-2y
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 05:00:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbR7s-0003OF-2F
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 05:00:05 -0400
Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:52792)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WbR7r-0003Ny-RY
	for emacs-orgmode@gnu.org; Sat, 19 Apr 2014 04:59:55 -0400
Received: by mail-wi0-f169.google.com with SMTP id hm4so282655wib.4
	for <emacs-orgmode@gnu.org>; Sat, 19 Apr 2014 01:59:54 -0700 (PDT)
In-Reply-To: <m2ppke1izt.fsf@polytechnique.org> (Alan Schmitt's message of
	"Fri, 18 Apr 2014 22:27:02 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Hi Alan,

thanks for sharing -- some comments:

- you need to update the copyright of the file;

- example code in section 3 of the header is mangled;

- there are some dangling parentheses;

- use (get-text-property (point-min) ...) instead of
  (get-text-property 1 ...)

- I'd use org-review instead of org-review-schedule as prefix;

- maybe you can use "naked" timestamps like 2014-04-19 sam.
  instead of inactive ones, this way using "[" in the agenda
  will not create false positives by inserting entries with
  a REVIEW property.

- I infer from a quick read that this works for the agenda but
  I guess this could work for both the agenda and Org buffers;

Since you took inspirationg from org-expiry, I guess some of
the comments above would apply there too... feel free to hack
into this directions for both org-expiry.el and org-review.el!
Actually, maybe both should be merged somehow, since expiring
is just reviewing entries to interactively delete them.

Thanks for this!

-- 
 Bastien